Skip to content

Fix/tidy and gd tests#2527

Open
nickchomey wants to merge 10 commits into
WordPress:trunkfrom
nickchomey:fix/tidy-and-gd-tests
Open

Fix/tidy and gd tests#2527
nickchomey wants to merge 10 commits into
WordPress:trunkfrom
nickchomey:fix/tidy-and-gd-tests

Conversation

@nickchomey

Copy link
Copy Markdown
Contributor

Summary

Fixes #2524
Depends on #2523 (I cant be bothered to rebase back to trunk, and then back on top when that gets merged)

Relevant technical choices

I noticed some strange/redundant code in the dominant-color-images plugin so took it as an opportunity to do a bit of tidying up as well as implement tests for GD.

The commits are self-describing. Let me know if it is necessary to split this into a few PRs...

Use of AI Tools

I used Deepseek V4 via VS Code Github Copilot Chat to assist me. I reviewed and refactored its output.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: nickchomey <nickchomey@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@nickchomey
nickchomey force-pushed the fix/tidy-and-gd-tests branch from 29a3234 to ea2c183 Compare June 8, 2026 15:33
@nickchomey
nickchomey force-pushed the fix/tidy-and-gd-tests branch from ea2c183 to 30c680c Compare June 25, 2026 19:14
@github-actions github-actions Bot added the [Plugin] Image Placeholders Issues for the Image Placeholders plugin (formerly Dominant Color Images) label Jun 25, 2026
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.27%. Comparing base (98437a5) to head (30c680c).
⚠️ Report is 2 commits behind head on trunk.

Files with missing lines Patch % Lines
plugins/dominant-color-images/helper.php 78.94% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk    #2527      +/-   ##
==========================================
+ Coverage   70.10%   70.27%   +0.17%     
==========================================
  Files          91       91              
  Lines        7823     7818       -5     
==========================================
+ Hits         5484     5494      +10     
+ Misses       2339     2324      -15     
Flag Coverage Δ
multisite 70.27% <85.18%> (+0.17%) ⬆️
single 35.85% <85.18%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Image Placeholders Issues for the Image Placeholders plugin (formerly Dominant Color Images)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug/improvement: The pattern in the dominant-color-images plugin's test functions doesn't make sense

1 participant