Fix/tidy and gd tests#2527
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
29a3234 to
ea2c183
Compare
…sed for initial image processing and dominant colours
…never do anything in any test
…ominant_color_get_dominant_color_data. So not redundant to call it afterwards
…e GD tests tun, though not for imagick)
…t stuff coming in other PR. Also, cleaner to just convert in one place for all editors
ea2c183 to
30c680c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #2527 +/- ##
==========================================
+ Coverage 70.10% 70.27% +0.17%
==========================================
Files 91 91
Lines 7823 7818 -5
==========================================
+ Hits 5484 5494 +10
+ Misses 2339 2324 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Fixes #2524
Depends on #2523 (I cant be bothered to rebase back to trunk, and then back on top when that gets merged)
Relevant technical choices
I noticed some strange/redundant code in the dominant-color-images plugin so took it as an opportunity to do a bit of tidying up as well as implement tests for GD.
The commits are self-describing. Let me know if it is necessary to split this into a few PRs...
Use of AI Tools
I used Deepseek V4 via VS Code Github Copilot Chat to assist me. I reviewed and refactored its output.