Keep SVG URLs remote during export#855
Merged
Merged
Conversation
scruffian
approved these changes
Jun 23, 2026
scruffian
left a comment
scruffian
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
One question - Is it worth detecting whether URL is a network accessible global domain rather than a local one?
Contributor
Author
I don't think it's worth the complexity, there's a lot of dev environments (docker, playground, etc) we would have to consider. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates media export so SVG URLs found in templates and patterns are left at their original URL instead of being copied into the generated theme assets. Raster images and supported video files continue to be localized as before.
This aligns the plugin with WordPress core’s handling of SVGs: themes can still include their own SVG assets, but SVG files from content/media URLs are not treated like ordinary localizable image uploads by default.
Test plan
npm run test:unit:php:base -- --filter 'Test_Create_Block_Theme_Media|Test_Create_Block_Theme_Zip'vendor/bin/phpcs --standard=phpcs.xml.dist includes/create-theme/theme-media.php tests/test-theme-media.php tests/test-theme-zip.php