fix: OTA target scaling uses height for both dimensions#2147
Open
Mr-Neutr0n wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
OTA target coordinate normalization uses the height dimension for both x and y scaling. The x coordinate should be normalized by width and y by height.
Fix
Corrected the scaling to use the appropriate dimension for each coordinate.
In
utils/loss.py, the target xywh coordinates are converted from normalized [0,1] space to pixel space. The original code multiplies all four values (x, y, w, h) byimgs[batch_idx].shape[1](height), but x and w should useshape[2](width) instead. This affectsComputeLossOTA,ComputeLossBinOTA, andComputeLossAuxOTA.The fix changes the scalar multiplication to a per-coordinate tensor
[W, H, W, H]so that x/w scale by width and y/h scale by height.