refactor(core): remove forge type re-export from sessions/types/safety.rs#597
Merged
Merged
Conversation
…y.rs Stop re-exporting PrCheckResult through the sessions module boundary. Callers now import directly from forge::types, respecting the module boundary between sessions and forge domains. Closes #591
These four tests are identical copies of tests already in forge/types.rs. With the re-export removed, tests for PrCheckResult belong only in the forge module where the type is defined.
- Replace array-of-Options iterator pipeline with explicit if-blocks for building warning message parts - Import MergeStrategy alongside PrCheckResult, removing 3 repeated qualified paths - Flatten double-borrow workaround in destroy.rs into a destructuring let
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PrCheckResultthroughsessions::types::safetymodule boundarydestroy.rs,types/tests.rs) now import directly fromforge::typesTest plan
cargo fmt --checkpassescargo clippy --all -- -D warningspassescargo test --allpasses (all 25 test suites)cargo build --allpassesCloses #591