UnityAds Adapter: 4.18.0 api migration#3
Merged
AnwarissaAsbah merged 8 commits intoJun 29, 2026
Conversation
lmoreault
reviewed
Jun 3, 2026
lmoreault
left a comment
lmoreault
left a comment
There was a problem hiding this comment.
Mostly LGTM, just small nit picks or comments 👍
| privacyMetaData.set( "privacy.mode", "mixed" ); | ||
| privacyMetaData.commit(); | ||
| // No COPPA trafic supported | ||
| UnityAds.setNonBehavioral(false); |
There was a problem hiding this comment.
Shall we really hard code this to false? @UnitySteven Do you recall if we should be explicit here like this or keep it not set? (we didn't set it before)
Author
There was a problem hiding this comment.
updating it. Initially, the privacy team requested that its hard coded to false then got back to us and asked us to leave it unset.
| log( "Showing interstitial ad for placement \"" + placementId + "\"..." ); | ||
|
|
||
| UnityAds.show( activity, placementId, createAdShowOptions(), new IUnityAdsShowListener() | ||
| loadedInterstitialAd.show( activity, new ShowConfiguration.Builder().build(), new InterstitialShowListener() |
There was a problem hiding this comment.
Same for the 3 types, but we should null check I believe to avoid NPE in case user didn't call load first
| .withMediationInfo( createMediationInfo() ) | ||
| .build(); | ||
|
|
||
| UnityAds.initialize( config, new InitializationListener() |
There was a problem hiding this comment.
Most listeners could be simply lambdas (init, load, etc.)
lmoreault
reviewed
Jun 4, 2026
| # Changelog | ||
|
|
||
| ## 4.18.1.1 | ||
| * Migrated to Unity Ads SDK 4.x new experimental API (`InitializationConfiguration`, `InterstitialAd`, `RewardedAd`, `BannerAd`, `LoadConfiguration`, `ShowConfiguration`). |
lmoreault
approved these changes
Jun 4, 2026
AnwarissaAsbah
added a commit
that referenced
this pull request
Jun 29, 2026
* dynamic size * Update build.gradle revent changes * Update settings.gradle revert changes * bump version * null handling * Update UnityAdsMediationAdapter.java * Delete .gradle/config.properties * UnityAds Adapter: 4.19.0 api migration (#3) * UnityAds Adapter: 4.18.0 api migration * Update UnityAdsMediationAdapter.java * Update UnityAdsMediationAdapter.java * Update CHANGELOG.md * Update UnityAdsMediationAdapter.java * Update UnityAdsMediationAdapter.java * update change log --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update banner implementation to use the new apis