Dominos with Dominos Overhaul (#209)#222
Open
PointerRain wants to merge 6 commits into
Open
Conversation
PointerRain
added
enhancement
PointerRain
marked this pull request as ready for review
March 25, 2025 12:12
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR overhauls the dominos coupons cog by using Domino's official sources of coupons. They are sourced using the process described in #209.
There are now two commands
/dominos couponsand/dominos stores. Their capabilities are very similar but have slightly different filters and processes. The/dominos couponscommand will list coupons in the same way as always but with an optional choice of store (default to St Lucia) and service method (Delivery or Pickup (or Dine-in exists technically)). The/dominos storescommand works as described in #209, with the user selecting a store from a dropdown and viewing details about a store before viewing coupons. Instead of a 'no-check' flag, if a store matches the user's search term it will skip the selection process and only return that store.The change also introduces a
utils/dominos_utils.pyfile where the main searching and filtering logic is implemented.