Skip to content

[FR-U] Align Medication examples (#325) - #332

Open
jldalisay95 wants to merge 5 commits into
UPM-NTHC:mainfrom
jldalisay95:issue-325-medication-examples-alignment
Open

[FR-U] Align Medication examples (#325)#332
jldalisay95 wants to merge 5 commits into
UPM-NTHC:mainfrom
jldalisay95:issue-325-medication-examples-alignment

Conversation

@jldalisay95

@jldalisay95 jldalisay95 commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

Aligns the PH Core Medication examples for #325 by using the canonical standalone Medication example and removing hardcoded source narratives.

Related Issue

Closes #325
Parent: #305

Type of Work

  • Profile
  • Extension
  • CodeSystem
  • ValueSet
  • ConceptMap
  • Example
  • Narrative Page
  • Documentation
  • Test Script
  • CI/Build Infrastructure
  • Other

Changes Made

  • Removed the empty inline example-medication instance from transaction-example.fsh.
  • Kept the transaction bundle reference to Medication/medication-single-example.
  • Removed hardcoded text.status and text.div from medication-single-example.
  • Preserved medication-single-example as a PHCoreMedication example.
  • Preserved PHFDACPRCS#DRP-10144 (Twinact) and the text Twinact 40mg/5mg tablet.
  • Synced the branch with the latest upstream main and resolved the transaction-example.fsh merge conflict by retaining the standalone Observation and Medication references.
  • Retained the removal of the inline Practitioner narrative requested during review.

Validation / Testing

  • IG builds successfully (sushi . with 0 errors)
  • Examples validate
  • Terminology checked
  • Links verified
  • Other: Full local IG Publisher build completed using the CI-pinned Publisher 2.2.7.

Validation results:

  • SUSHI 3.18.1: 0 errors, 0 warnings.
  • IG Publisher 2.2.7 with -tx n/a: 0 errors, 141 warnings, 0 broken links.
  • Generated transaction bundle contains Medication/medication-single-example.
  • Generated source Medication and Practitioner resources contain no hardcoded narrative.
  • git diff --check passed.

The Windows Jekyll process exceeded the Publisher's reporting timeout shortly after completing, but the Publisher proceeded successfully, generated the final package and QA report, and returned exit code 0.

Reviewer Notes

The branch is synchronized with upstream main, and the prior GitHub merge conflict is resolved. The remaining PR diff against current main is limited to removing the Medication narrative and the empty inline Medication shell.

Preview / Screenshots

Fork branch preview:
https://build.fhir.org/ig/jldalisay95/ph-core-jld/tree/issue-325-medication-examples-alignment

@jldalisay95
jldalisay95 requested review from a team June 5, 2026 07:19
@jldalisay95

jldalisay95 commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator Author

@niccoreyes This PR addresses the medication-specific scope in #325.

It removes the empty example-medication shell from transaction-example.fsh, updates the transaction bundle to use Medication/medication-single-example, and removes the hardcoded narrative from medication-single-example.

I kept the PR narrow and did not remove the other embedded transaction examples or their narratives because #330 appears to cover the final transaction bundle cleanup after the sub-issues are complete.

This was referenced Jun 8, 2026
Open
Closed
@niccoreyes

niccoreyes commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

This PR has been on my tab for review, please wait as I just confirm a few things in the CI/CD

@niccoreyes
niccoreyes force-pushed the issue-325-medication-examples-alignment branch from 33d0ded to f8111ad Compare June 9, 2026 05:30
niccoreyes
niccoreyes requested changes Jun 10, 2026
View reviewed changes
Comment thread input/fsh/examples/transaction-example.fsh Outdated
johnscarter
johnscarter requested changes Jun 10, 2026
View reviewed changes

@johnscarter johnscarter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment inline from Doc Thomas

niccoreyes added a commit to niccoreyes/ph-core that referenced this pull request Jun 12, 2026
@niccoreyes
feat(examples): Add comprehensive ACS clinical case examples (UPM-NTH…
4e2946c 
…C#305)

Add 17 new FSH example files for a unified Acute Coronary Syndrome
clinical case at Philippine General Hospital, addressing issue UPM-NTHC#305.

Clinical Scenario:
- Patient: Juan Dela Cruz, 45M, Filipino, with T2DM history
- Presenting complaint: Crushing substernal chest pain (8/10)
- Diagnosis: Anterior STEMI (ST-elevation V1-V4, troponin 2.5 ng/mL)
- Treatment: Emergency PCI with drug-eluting stent to LAD
- Disposition: Transferred to CCU

New Resources Created:
- Patient: patient-acs-example (Juan Dela Cruz)
- Organization: organization-pgh-example (Philippine General Hospital)
- Location: location-ed-example (PGH ED Bay 3)
- Practitioner: practitioner-ed-example (Dr. Maria Clara Santos)
- PractitionerRole: practitionerrole-ed-example (ED Attending)
- Conditions: condition-acs-example, condition-t2dm-example
- Encounter: encounter-ed-example (ED visit, 08:30-10:30)
- Observations: 13 total (7 vital signs + 6 labs/diagnostics)
  - Vitals: BP, HR, RR, SpO2, Temp, Pain
  - Labs: Troponin, Glucose, HbA1c, Total Cholesterol, LDL, ECG
- Procedure: procedure-pci-example (PCI with stent)
- ServiceRequest: servicerequest-pci-example (Cardiology consult)
- MedicationRequests: 3 (Aspirin 325mg, Clopidogrel 600mg, Metoprolol 25mg)
- AllergyIntolerance: allergy-penicillin-example (high criticality)
- RelatedPerson: relatedperson-mother-example (Maria Cruz Santos)
- Composition: composition-ed-note-example (ED clinical note)
- Bundle: bundle-acs-case-example (Transaction bundle, 30 entries)

Also updated aliases.fsh to add missing terminology aliases:
- allergyintolerance-verification
- v3-ParticipationType
- immunization-funding-source
- admit-source
- discharge-disposition
- diagnosis-role

Alignment Rules Followed (per UPM-NTHC#305):
- Single patient identity across all resources (Juan Dela Cruz)
- Single practitioner (Dr. Maria Clara Santos) and organization (PGH)
- Consistent PSGC-coded addresses for all Philippine locations
- No hardcoded text.div narratives (publisher-generated)
- All resources use PH Core profiles
- All examples compile with SUSHI (0 errors)

Closes UPM-NTHC#305
Refs UPM-NTHC#306, UPM-NTHC#307, UPM-NTHC#308, UPM-NTHC#309, UPM-NTHC#310, UPM-NTHC#311, UPM-NTHC#312, UPM-NTHC#313, UPM-NTHC#314, UPM-NTHC#315, UPM-NTHC#316, UPM-NTHC#317, UPM-NTHC#318, UPM-NTHC#319, UPM-NTHC#320, UPM-NTHC#321, UPM-NTHC#322, UPM-NTHC#323, UPM-NTHC#324, UPM-NTHC#325, UPM-NTHC#326, UPM-NTHC#327, UPM-NTHC#328, UPM-NTHC#329, UPM-NTHC#330, UPM-NTHC#331, UPM-NTHC#332, UPM-NTHC#333, UPM-NTHC#334, UPM-NTHC#335, UPM-NTHC#336, UPM-NTHC#337, UPM-NTHC#338, UPM-NTHC#339, UPM-NTHC#340, UPM-NTHC#341, UPM-NTHC#342, UPM-NTHC#343, UPM-NTHC#344
@jldalisay95

jldalisay95 commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator Author

@johnscarter The inline feedback from @niccoreyes has been addressed. The branch is synchronized with the latest main, the merge conflict is resolved, and the full local IG build completed with 0 errors and 0 broken links. The updated changes are ready for review.

gpfvillanueva pushed a commit that referenced this pull request Jun 17, 2026
@niccoreyes
feat(examples): Add comprehensive ACS clinical case examples (#305) (#…
44c81b3 
…347)

* feat(examples): Add comprehensive ACS clinical case examples (#305)

Add 17 new FSH example files for a unified Acute Coronary Syndrome
clinical case at Philippine General Hospital, addressing issue #305.

Clinical Scenario:
- Patient: Juan Dela Cruz, 45M, Filipino, with T2DM history
- Presenting complaint: Crushing substernal chest pain (8/10)
- Diagnosis: Anterior STEMI (ST-elevation V1-V4, troponin 2.5 ng/mL)
- Treatment: Emergency PCI with drug-eluting stent to LAD
- Disposition: Transferred to CCU

New Resources Created:
- Patient: patient-acs-example (Juan Dela Cruz)
- Organization: organization-pgh-example (Philippine General Hospital)
- Location: location-ed-example (PGH ED Bay 3)
- Practitioner: practitioner-ed-example (Dr. Maria Clara Santos)
- PractitionerRole: practitionerrole-ed-example (ED Attending)
- Conditions: condition-acs-example, condition-t2dm-example
- Encounter: encounter-ed-example (ED visit, 08:30-10:30)
- Observations: 13 total (7 vital signs + 6 labs/diagnostics)
  - Vitals: BP, HR, RR, SpO2, Temp, Pain
  - Labs: Troponin, Glucose, HbA1c, Total Cholesterol, LDL, ECG
- Procedure: procedure-pci-example (PCI with stent)
- ServiceRequest: servicerequest-pci-example (Cardiology consult)
- MedicationRequests: 3 (Aspirin 325mg, Clopidogrel 600mg, Metoprolol 25mg)
- AllergyIntolerance: allergy-penicillin-example (high criticality)
- RelatedPerson: relatedperson-mother-example (Maria Cruz Santos)
- Composition: composition-ed-note-example (ED clinical note)
- Bundle: bundle-acs-case-example (Transaction bundle, 30 entries)

Also updated aliases.fsh to add missing terminology aliases:
- allergyintolerance-verification
- v3-ParticipationType
- immunization-funding-source
- admit-source
- discharge-disposition
- diagnosis-role

Alignment Rules Followed (per #305):
- Single patient identity across all resources (Juan Dela Cruz)
- Single practitioner (Dr. Maria Clara Santos) and organization (PGH)
- Consistent PSGC-coded addresses for all Philippine locations
- No hardcoded text.div narratives (publisher-generated)
- All resources use PH Core profiles
- All examples compile with SUSHI (0 errors)

Closes #305
Refs #306, #307, #308, #309, #310, #311, #312, #313, #314, #315, #316, #317, #318, #319, #320, #321, #322, #323, #324, #325, #326, #327, #328, #329, #330, #331, #332, #333, #334, #335, #336, #337, #338, #339, #340, #341, #342, #343, #344

* feat(examples): Simplify ACS clinical case to core PH Core resources (#305)

Remove 6 non-core resources to keep the case lean and focused:
- Location, Procedure, ServiceRequest, MedicationRequest
- AllergyIntolerance, RelatedPerson

Keep 9 core resources that exercise PH Core uniqueness:
- Patient, Encounter, Organization, Condition, Observation
- Practitioner, PractitionerRole, Composition, Bundle

Also updated:
- Composition: removed sections for medications, allergies, procedures
- Bundle: reduced from 30 to 21 entries (core resources only)
- Encounter: removed location references, simplified hospitalization
- Aliases: removed unused terminology aliases

Closes #305

* feat: Add ACS ED Triage sample case with REST API tutorial (#305)

- Create comprehensive sample-case.md tutorial page with FHIR REST API
  basics (GET, POST, PUT, PATCH, DELETE, Bundle transactions)
- Fix FSH example files for clean IG Publisher validation:
  - Patient: religion display, address, remove contact
  - Observation: combine BP components, fix LOINC codes
  - Condition: SNOMED display
  - Encounter: remove dischargeDisposition
  - PractitionerRole: remove dangling location reference
  - Composition: LOINC displays
  - Labs: glucose/LDL codes
  - Bundle: updated for combined BP
- Add 'Sample Case' menu item in sushi-config.yaml
- Style tables with CSS (borders, alternating rows, hover)
- All examples validated against tx.fhir.org
- Tested against https://cdr.fhirlab.net/fhir

Fixes #305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@niccoreyes niccoreyes niccoreyes approved these changes
@johnscarter johnscarter johnscarter approved these changes

Assignees

@niccoreyes niccoreyes

@jldalisay95 jldalisay95

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FR-U] Medication Examples Alignment

3 participants

@jldalisay95 @niccoreyes @johnscarter