Update Walkercreek for Nextflow 26 strict compatibility - #19
Conversation
jwarnn
left a comment
There was a problem hiding this comment.
I ran three test runs; twice with a custom samplesheet and once with the test profile. They all completed successfully. I am approving the PR but left a comment to consider about lowering the required nextflowversion in the manifest.
| defaultBranch = 'master' | ||
| nextflowVersion = '>=24.04.2' | ||
| version = '4.0' | ||
| nextflowVersion = '>=26.04.1' |
There was a problem hiding this comment.
I tested the pipeline at a lower version using NXF_VER=24.04.2 . The run executed with no problem. I am not sure of the importance of this line of the manifest; I have had runs stop if the version is lower than what the manifest says is required but that didn't happen for this run. It might be more accessible if older versions are allowed. Maybe consider keeping nextflowVersion = '>=24.04.2'
There was a problem hiding this comment.
I agree the manifest should show the minimum supported version. Thanks for testing it. I’ll keep nextflowVersion = '>=24.04.2' to show support for users on older versions.
Keep Nextflow minimum version at 24.04.2 so the pipeline remains accessible to users on older supported Nextflow version. The pipeline will still execute successfully.
Summary
This PR updates Walkercreek to run successfully with Nextflow 26.04.1 using the v2 strict syntax parser.
This makes the pipeline compliant with newer Nextflow syntax requirements while preserving existing workflow behavior across the supported Walkercreek platforms.
Major changes
nextflowVersionchanged to>=26.04.14.1.0SEQKIT_PAIRissue caused by shell variable interpolation in the gzip step..versionsoutput errors.bin/generate_summary_alerts.py.summary_alerts.tsvis generated consistently.ref/h3n2_barcode.html.Validation performed
I tested the updated pipeline with Nextflow 26.04.1 and the v2 strict syntax parser:
I also tested all Walkercreek platforms successfully after the strict-parser updates.
Tested platforms:
I also tested summary_alerts.tsv generation using known influenza coinfection samples and confirmed that alerts are now generated where expected.