fix(ui): morph workspace AI-config Save button into Test until verified#343
Merged
Conversation
The Save button was gated on a passing connection test (dirty && testPassedForCurrent), but the only cue was a hover-only title — users filled the form and couldn't tell why Save stayed greyed out. Collapse the footer's separate Test/Save buttons into one primary CTA that walks the gate: an unverified change shows Test, and only a passing reply morphs it into Save. The lit button is always the next action, so the "test before save" rule is self-evident without reading any hint. The gate itself (needsTest = dirty && !testPassedForCurrent) is unchanged — an unverified credential still can't be saved. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
title— users filled the form and couldn't tell why Save stayed greyed out.needsTest = dirty && !testPassedForCurrent) is unchanged — an unverified credential still can't be saved.Test plan
cd ui && npx tsc -bcleanBoundary touch
None — pure UI affordance change in
WorkspaceAIConfigModal.tsx; no trading/auth/broker/migration paths touched.🤖 Generated with Claude Code