Touch a temp tiddler when removing a tag#9889
Open
BurningTreeC wants to merge 2 commits into
Open
Conversation
Like that removing a tag doesn't make TiddlyWiki5 wait for the Typing timeout to remove it but removes it instantly, because also a non-draft Tiddler has changed
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Confirmed: BurningTreeC has already signed the Contributor License Agreement (see contributing.md) |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2491.8 KB |
| PR | 2491.9 KB |
Diff: ⬆️ Increase: +0.1 KB
✅ Change Note Status
All change notes are properly formatted and validated!
📝 $:/changenotes/5.4.1/#9889
Type: bugfix | Category: usability
Release: 5.4.1
Make tags in Edit Mode animate instantly when removing
🔗 #9889
👥 Contributors: BurningTreeC
📖 Change Note Guidelines
Change notes help track and communicate changes effectively. See the full documentation for details.
Member
|
LGTM |
Fixes an issue where tags of Tiddlers in Edit Mode don't animate instantly when they get removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like that removing a tag doesn't make TiddlyWiki5 wait for the Typing timeout to remove it but removes it instantly, because also a non-draft Tiddler has changed.
The issue:
Try the same steps in the preview of this PR