Explain table WikiText handling TODO comment#9803
Conversation
❌ Deploy Preview for tiddlywiki-previews failed. Why did it fail? →
|
|
Confirmed: andrewgoz has already signed the Contributor License Agreement (see contributing.md) |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2489.5 KB |
| PR | 2489.5 KB |
Diff: ⬆️ Increase: +0.1 KB
✅ Change Note Status
All change notes are properly formatted and validated!
📝 $:/changenotes/5.4.0/#9803
Type: enhancement | Category: usability
Release: 5.4.0
Re-enable WikiText table caption positioning
🔗 #9803
👥 Contributors: andrewg_oz
📖 Change Note Guidelines
Change notes help track and communicate changes effectively. See the full documentation for details.
andrewgoz
left a comment
There was a problem hiding this comment.
Added release note
|
What does TODO comment mean here? Did you see #6865 |
This is unrelated to #6865. The TODO is referring to TiddlyWiki Classic code that was disabled, apparently because it was not understood at the time code was being ported to TiddlyWiki 5. It's a bit disappointing, because it means TW5 has never been backward-compatible with this little detail of TWC table caption handling. This PR is draft because I want to update WikiText examples. I hope to do that in a week or two. |
The caption processing is best explained using two WikiText tables:
and
in both cases the HTML
<caption>element is made the first child of the<table>element - as it should be.I also changed the
slice()tounshift(), because I find the latter more clear. The comment associated with that was simply wrong.