Skip to content

Explain table WikiText handling TODO comment#9803

Draft
andrewgoz wants to merge 5 commits into
TiddlyWiki:masterfrom
andrewgoz:master
Draft

Explain table WikiText handling TODO comment#9803
andrewgoz wants to merge 5 commits into
TiddlyWiki:masterfrom
andrewgoz:master

Conversation

@andrewgoz

Copy link
Copy Markdown
Contributor

The caption processing is best explained using two WikiText tables:

|shown above table|c
|!h1|!h2|h
|d1|d2|

and

|!h1|!h2|h
|d1|d2|
|shown below table|c

in both cases the HTML <caption> element is made the first child of the <table> element - as it should be.

I also changed the slice() to unshift(), because I find the latter more clear. The comment associated with that was simply wrong.

@netlify

netlify Bot commented Apr 13, 2026

Copy link
Copy Markdown

Deploy Preview for tiddlywiki-previews failed. Why did it fail? →

Name Link
🔨 Latest commit f317231
🔍 Latest deploy log https://app.netlify.com/projects/tiddlywiki-previews/deploys/69f5e4e06f9a120008824830

@github-actions

Copy link
Copy Markdown

Confirmed: andrewgoz has already signed the Contributor License Agreement (see contributing.md)

@github-actions

github-actions Bot commented Apr 13, 2026

Copy link
Copy Markdown

📊 Build Size Comparison: empty.html

Branch Size
Base (master) 2489.5 KB
PR 2489.5 KB

Diff: ⬆️ Increase: +0.1 KB


✅ Change Note Status

All change notes are properly formatted and validated!

📝 $:/changenotes/5.4.0/#9803

Type: enhancement | Category: usability
Release: 5.4.0

Re-enable WikiText table caption positioning

🔗 #9803

👥 Contributors: andrewg_oz


📖 Change Note Guidelines

Change notes help track and communicate changes effectively. See the full documentation for details.

@andrewgoz andrewgoz marked this pull request as draft April 14, 2026 16:01

@andrewgoz andrewgoz left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added release note

@andrewgoz andrewgoz marked this pull request as ready for review April 14, 2026 16:25
@andrewgoz andrewgoz marked this pull request as draft May 2, 2026 11:51
@linonetwo

Copy link
Copy Markdown
Contributor

What does TODO comment mean here? Did you see #6865

@andrewgoz

Copy link
Copy Markdown
Contributor Author

What does TODO comment mean here? Did you see #6865

This is unrelated to #6865. The TODO is referring to TiddlyWiki Classic code that was disabled, apparently because it was not understood at the time code was being ported to TiddlyWiki 5. It's a bit disappointing, because it means TW5 has never been backward-compatible with this little detail of TWC table caption handling.

This PR is draft because I want to update WikiText examples. I hope to do that in a week or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants