Skip to content

Sensocon fix pr 1#945

Open
jenkinsheath wants to merge 6 commits into
TheThingsNetwork:masterfrom
jenkinsheath:sensocon-fix-PR-1
Open

Sensocon fix pr 1#945
jenkinsheath wants to merge 6 commits into
TheThingsNetwork:masterfrom
jenkinsheath:sensocon-fix-PR-1

Conversation

@jenkinsheath

@jenkinsheath jenkinsheath commented Aug 12, 2025

Copy link
Copy Markdown

Summary

  • Title and description should be descriptive (Not just a serial number for example).
  • profileIDs should not be vendorID and should be a unique value for every profile.
  • All devices should be listed in the vendor's index.yaml file.
  • Firmware versions can not be changed.
  • At least 1 image per device and should be transparent.

Notes for Reviewers

...

Release Notes

  • ...

@jenkinsheath jenkinsheath left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed all requested changes and believe that this is ready to be approved. Thank you -

@Jaime-Trinidad

Copy link
Copy Markdown
Contributor

Hi @jenkinsheath there are still issues with the files, I recommend you to take a look to the vendor/example files and address the missing fields and files

@Jaime-Trinidad

Jaime-Trinidad commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

Any updates? @jenkinsheath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants