Skip to content

Split wind speed into avg & gust, added water measurements. #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dajtxx wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Split wind speed into avg & gust, added water measurements. #568

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a8b8550
Split wind speed into avg & gust, added water measurements.
dajtxx Dec 9, 2022
686ed51
Changed avg to average, removed water ec while determining what the u…
dajtxx Dec 29, 2022
9cc83e4
Merge pull request #1 from TheThingsNetwork/master
dajtxx Jun 13, 2023
aad613e
Removed averageSpeed in the wind section.
dajtxx Jun 13, 2023
d70955a
Merge pull request #2 from TheThingsNetwork/master
dajtxx Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion lib/payload.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,11 @@
"type": "object",
"properties": {
"speed": {
"description": "Wind speed (m/s)",
"description": "Instantaneous or average wind speed (m/s)",

@pablojimpas pablojimpas Jun 15, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to avoid documenting/promoting the use of average here until we figure out a way to introduce grouping and stats.

Suggested change
"description": "Instantaneous or average wind speed (m/s)",
"description": "Wind speed (m/s)",

"$ref": "#/definitions/speed"
},
"gustSpeed": {
"description": "Maximum wind speed during the measurement interval (m/s)",

@pablojimpas pablojimpas Jun 15, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer not making assumptions on how the gust speed is calculated:

Suggested change
"description": "Maximum wind speed during the measurement interval (m/s)",
"description": "Gust wind speed (m/s)",

"$ref": "#/definitions/speed"
},
"direction": {
Comment on lines 133 to 138

@johanstokking johanstokking Dec 23, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good change. I think it is indeed useful domain knowledge to differentiate between average and gust wind speeds.

Can you turn it into averageSpeed though?

@dajtxx dajtxx Dec 29, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this is done.

Expand All @@ -137,6 +141,28 @@
}
},
"additionalProperties": false
},
"water": {
"type": "object",
"properties": {
"depth": {
"description": "Depth of water measurement (cm)",
"$ref": "#/definitions/depth"
},
"temperature": {
"description": "Water temperature (°C)",
"$ref": "#/definitions/temperature"
},
"pH": {
"description": "Water pH level",
"$ref": "#/definitions/pH"
},
"salinity": {
"description": "Salt (mg) per litre (ppm)",

@johanstokking johanstokking Jun 15, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're following en-US

Suggested change
"description": "Salt (mg) per litre (ppm)",
"description": "Salt (mg) per liter (ppm)",

"$ref": "#/definitions/concentration"
}
},
"additionalProperties": false
}
},
"additionalProperties": false
Expand Down