-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Solid router main merge #7628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Solid router main merge #7628
Changes from 46 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
7fc7c34
ci: Version Packages (#7525)
github-actions[bot] ccf87fb
docs: clarify auth data boundaries (#7537)
tannerlinsley 8091918
fix(start-rsbuild): compile node_modules for RSC directives (#7540)
SyMind 8c7e54e
ci: Version Packages (#7544)
github-actions[bot] 1d113f0
fix(examples): make isRoot check work (#7547)
ulrichstark bb99f66
refactor: remove unnecessary any assertions (#7542)
ulrichstark fee0b58
refactor: remove unused dependencies (#7541)
ulrichstark 3dcc016
improve bundle size benchmarks and add initial skill (#7450)
schiller-manuel 7a83e67
fix(router-core): retain search over validation defaults (#7549)
schiller-manuel fb0399e
fix build (#7550)
schiller-manuel 76b3d3b
Revert #7524 (#7533)
birkskyum 301f6ba
fix(start): clean up server function handler imports (#7552)
schiller-manuel 6b453df
fix build (#7553)
schiller-manuel 2cca73c
fix(router-core): fix search middleware type to use schema output (#7…
sprusr a8647d2
ci: Version Packages (#7554)
github-actions[bot] ac10815
fix(router-core): respect stripped params in retainSearchParams (#7555)
schiller-manuel 65ad906
ci: Version Packages (#7556)
github-actions[bot] e99e855
add regression tests (#7557)
schiller-manuel df1076c
fix(router-core): allow retained search params to reset to defaults (…
schiller-manuel 837897f
fix(router-plugin): preserve generated route state for aliased HMR im…
schiller-manuel 996b9be
ci: Version Packages (#7561)
github-actions[bot] 776d8ef
fix(router-core): skip scroll restoration setup when disabled (#7562)
schiller-manuel 10a7ff8
ci: Version Packages (#7563)
github-actions[bot] 9bebf8d
rename inputValidator to validator (#7566)
schiller-manuel 757d433
ci: Version Packages (#7567)
github-actions[bot] 4a93cff
refactor(react-router): useMatches skips useRef during SSR (#7575)
Sheraff f111a38
docs: add 🟡 (Experimental) for TanStack Start RSC support (#7573)
NandkishorJadoun b80781e
fix(benchmarks): run SSR setup imports natively (#7579)
Sheraff 689d88e
refactor(react-router): Reduce bundle size by sharing hook structural…
Sheraff 5127d86
refactor(router-core): avoid creating promises when not necessary (#7…
Sheraff 41e7a24
refactor(solid-router): remove unnecessary setTimeout from Match comp…
Sheraff 6f1daf5
chore: update nx to 22.7.5 (#7583)
beaussan 52db703
fix(react-router): avoid throwing in useMatch selector (#7595)
Sheraff 56bd271
perf(react-router): add match selector compares (#7596)
Sheraff f046b06
chore: forgot changeset in #7596 (#7600)
Sheraff 96eca43
perf(start-server-core): skip update for server context (#7599)
Sheraff 6f882b7
docs(start): rename LLM optimization guide to GEO (#7620)
tannerlinsley 2215277
docs(router): drop the broken "LLM Assistance Support" nav entry (#7617)
tsushanth 0c110a9
ssr benchmarks (#7606)
Sheraff a2b9d51
docs: fix duplicate "to" typos (#7370)
dfedoryshchev 36ed574
bench: calibrate new ssr benchmarks iteration to reduce variability (…
Sheraff 689c5ab
chore(react-router): silence AbortError in renderRouterToStream (#7627)
Sheraff 1052ab9
Merge branch 'main' into solid-router-main-merge2
brenelz 545866d
chore: fix tests
brenelz 0747d9b
ci: apply automated fixes
autofix-ci[bot] 3fe770a
fix: update solid ssr benchmark types
brenelz 144ddc7
chore: remove unneeded changesets
brenelz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../skills/bundle-size-optimization |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@tanstack/react-router': patch | ||
| --- | ||
|
|
||
| Perf improvement of useMatch and derived hooks when navigating away from previous match | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@tanstack/react-router': patch | ||
| --- | ||
|
|
||
| useMatches can skip useRef for structural sharing during SSR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@tanstack/start-server-core': patch | ||
| --- | ||
|
|
||
| Skip a full router.update for faster createStartHandler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@tanstack/react-router': patch | ||
| --- | ||
|
|
||
| Reduce Match rerenders during navigations (PR #7596) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@tanstack/solid-router': patch | ||
| --- | ||
|
|
||
| Remove unnecessary setTimeout from Match components |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@tanstack/react-router': patch | ||
| --- | ||
|
|
||
| Reduce bundle size by sharing structuralSharing selector logic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@tanstack/react-router': patch | ||
| --- | ||
|
|
||
| Silence AbortError in renderRouterToStream, this is normal operation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 13 additions & 1 deletion
14
benchmarks/bundle-size/scenarios/react-router-full/src/routes/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 13 additions & 1 deletion
14
benchmarks/bundle-size/scenarios/solid-router-full/src/routes/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 13 additions & 1 deletion
14
benchmarks/bundle-size/scenarios/vue-router-full/src/routes/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
benchmarks/bundle-size/scenarios/vue-start-full/src/router.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { createRouter } from '@tanstack/vue-router' | ||
| import { routeTree } from './routeTree.gen' | ||
|
|
||
| export function getRouter() { | ||
| return createRouter({ | ||
| routeTree, | ||
| scrollRestoration: true, | ||
| }) | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.