fix(solid-router): keep route-scoped accessors readable after navigation teardown#7607
1 benchmark regressed
⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 2 untouched benchmarks
⏩ 1 skipped benchmark1
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | ssr request loop (vue) |
420.3 ms | 484.6 ms | -13.27% |
| ⚡ | client-side navigation loop (solid) |
72.6 ms | 66.2 ms | +9.75% |
| ⚡ | ssr request loop (solid) |
174.6 ms | 162.5 ms | +7.46% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing brenelz:fix/solid-router-route-scoped-accessor-teardown (db4b860) with solid-router-v2-pre (67a9040)2
Footnotes
-
1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩
-
No successful run was found on
solid-router-v2-pre(65133ed) during the generation of this report, so 67a9040 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩