Precision-Recall Curve Bugfix #862
Merged
Merged
Conversation
rsbowman-striveworks
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
AP was inconsistent between
v0.36.6andv0.37.2(latest) when tested on a larger real-world datasetcalculate_ranking_boundarieswould sometimes include groundtruth-prediction pairs without matching labels in theiou_boundaryarray. This array should only include candidates for true positives.compute_countswould not necessarily return the maximum precision or score depending on ordering. When running over file-based chunks this would intermittently yield different results as there was more opportunity for the correct maximum value to be chosen.Both of these bugs resulted in small errors that could accumulate into larger errors if using file-based chunking.
Changes
calculate_ranking_boundariesto enforce label matching as a condition for inclusioncompute_countswith a new binning operation.