fix(programs): scope session-progress/start session to the enrolled program#231
Open
evan188199-tech wants to merge 1 commit into
Conversation
…rogram session-progress/start fetched the ProgramSession by id alone and never compared programSession.week.programId against enrollment.programId, so a request passing an enrollment in Program A with a sessionId from Program B created a UserSessionProgress pointing at the wrong program and overwrote the user's currentWeek/currentSession with that program's values. Reject any session whose week's programId doesn't match the enrollment's program. Fixes Snouzy#230
|
Someone is attempting to deploy a commit to the Workoutcool Team Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
此 PR 由 GLM-5.2 修复。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
POST /api/programs/session-progress/startcreated aUserSessionProgressfor any session id the client passed, without checking that the session belongs to the program the enrollment is for. The user's enrollment pointer (currentWeek/currentSession) was then overwritten with numbers from that unrelated session.Bug found while auditing the programs API — not covered by any existing issue/PR.
Root cause
In
app/api/programs/session-progress/start/route.ts:The enrollment captures
programId(program A), butprogramSession.week.programId(program B) is never compared.UserSessionProgressonly relates toProgramSession, not to the enrollment's program, so the schema doesn't enforce a match either.A request
{ enrollmentId: <enrollment in Program A>, sessionId: <Program-B session> }would (1) create a progress row linking a Program-A enrollment to a Program-B session, (2) overwrite the enrollment'scurrentWeek/currentSessionwith Program-B's values, (3) break the user's real position (thecompleteroute then inherits the wrong row).Fix
Reject any session whose week's
programIddoesn't match the enrollment's program:enrollment.programis already loaded andprogramSession.weekis already included, so no extra query is needed.Fixes #230.