drm: check for EINVAL when dropping master#2057
Open
amshafer wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using DRM leasing on the NVIDIA driver smithay may run into an error while trying to release master during
DrmLeaseState::new()->get_non_master_fd(). The NVIDIA driver marks all clients as authenticated, so when smithay does theget_client()call it erroneously assumes the fd has master and tries to drop it. Dropping master fails since the fd never had it to begin with.This change checks for EINVAL while releasing master. If we see EINVAL returned then we know that the fd, while potentially marked as authenticated, did not have master and therefore was unable to drop it.
Open to suggestions if you do not think this is the right fix.
Checklist