Add Serial buffer for performance improvement#533
Open
unlogisch04 wants to merge 13 commits into
Open
Conversation
Co-authored-by: unlogisch04 <98281608+unlogisch04@users.noreply.github.com>
Co-authored-by: unlogisch04 <98281608+unlogisch04@users.noreply.github.com>
Eirenliel
approved these changes
Jun 8, 2026
Member
|
Please rebase |
Contributor
|
|
Contributor
Author
|
good catch 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR goes on top of #532
Serial Writes did take up to 54ms to write out the SerialCommands::printState();
After digging deeper i found out that the esp8266 frameworks blocks till all chars are printed out.
In taking advantage of the HW Buffer (128Bytes), to only write the set amount of chars to the buffer the blocking behavior can be avoided. (from 54 ms to about ~400us each cycle)
Arduino has the free bytes to write in the function called
Serial.availableForWrite()With this change we can avoid long blocking serial operation.
the Logger function to print Arrays has been removed, and the only instance used converted.
There are many places Serial.Print.. is still used, that might show out of place: