Skip to content

add: TileJSON metadata enrichment, fix tests, and enable CI test runs#330

Open
herostrat wants to merge 5 commits into
SignalK:masterfrom
herostrat:up/tilejson
Open

add: TileJSON metadata enrichment, fix tests, and enable CI test runs#330
herostrat wants to merge 5 commits into
SignalK:masterfrom
herostrat:up/tilejson

Conversation

@herostrat

@herostrat herostrat commented Feb 14, 2026

Copy link
Copy Markdown
Contributor

TileJSON charts now pull missing metadata [minzoom] [maxzoom] [format] so map zoom/bounds and the info dialog show correct values.

In addition I wanted to add tests for this and found that the test framework was not working correctly and niot hooked up to the CI.
I fixed this.

I thought about adding the lockfile in order to be able to use npm ci (and than one could cache it in CI). I could add it if you'd like, but I didn't want to add another thing on top in this PR. I can send a PR afterwards with it or add it here - whatever you prefer.

Note: CI fails because it of errors fixed in this PR: #329
A CI can be seen here: See: herostrat#1

A visual before and after image:
image

@herostrat herostrat changed the title Up/tilejson Add TileJSON metadata enrichment, fix tests, and enable CI test runs Feb 14, 2026
@herostrat

Copy link
Copy Markdown
Contributor Author

I forgot to add format and the vector layers and fixed it now:
image
image

@herostrat herostrat changed the title Add TileJSON metadata enrichment, fix tests, and enable CI test runs add: TileJSON metadata enrichment, fix tests, and enable CI test runs Feb 14, 2026
@joelkoz

joelkoz commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the contribution. Can you remove all of the modifications to the CI and focus this on just the TileJSON fix. We've recently redone the CI to match the shared CI used across all the SignalK projects. If you can update the PR (including title and description) and rebase against the current master I can take another look.

@joelkoz joelkoz self-assigned this Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants