add: TileJSON metadata enrichment, fix tests, and enable CI test runs#330
Open
herostrat wants to merge 5 commits into
Open
add: TileJSON metadata enrichment, fix tests, and enable CI test runs#330herostrat wants to merge 5 commits into
herostrat wants to merge 5 commits into
Conversation
Contributor
Author
Collaborator
|
Thanks for the contribution. Can you remove all of the modifications to the CI and focus this on just the TileJSON fix. We've recently redone the CI to match the shared CI used across all the SignalK projects. If you can update the PR (including title and description) and rebase against the current master I can take another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


TileJSON charts now pull missing metadata [minzoom] [maxzoom] [format] so map zoom/bounds and the info dialog show correct values.
In addition I wanted to add tests for this and found that the test framework was not working correctly and niot hooked up to the CI.
I fixed this.
I thought about adding the lockfile in order to be able to use npm ci (and than one could cache it in CI). I could add it if you'd like, but I didn't want to add another thing on top in this PR. I can send a PR afterwards with it or add it here - whatever you prefer.
Note: CI fails because it of errors fixed in this PR: #329
A CI can be seen here: See: herostrat#1
A visual before and after image:
