fix(layout): prevent view holder container flattening - #2400
Open
wanxiankai wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2399
Prevent React Native view flattening from removing the
ViewHolderCollectioncontainer. This view provides the coordinate system and scroll extent for the
absolutely positioned item views, so flattening it can make rows lose content
padding and header offsets.
This change:
collapsable={false}, matching the outerRecyclerView container
Reviewers’ hat-rack 🎩
Screenshots or videos (if needed)
Not included. The failure depends on Fabric's native view-flattening decision;
the regression test verifies the required native view prop directly.
Testing
yarn test --runInBand --watchman=false(15 suites, 188 tests)yarn type-checkyarn lintyarn build