Fixes issue add support for more datatypes in filters (3)#62
Conversation
|
the lint errors should now be fixed |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #62 +/- ##
============================================
+ Coverage 72.54% 72.88% +0.33%
- Complexity 721 743 +22
============================================
Files 36 36
Lines 2302 2360 +58
============================================
+ Hits 1670 1720 +50
- Misses 632 640 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Have you considered writing (at least some) tests also for this PR? |
|
I have also answered here #58 -- regarding the tests for this PR I think so far it is good they passed since this should reflect the fact that the changes did not change the previous functioning, but only add/cover some other cases. For these, yes, I could write more tests. The related test currently is "filters.json", so it could be added another set of filters for instance with name filters_extended.json |
|
@gesinn-it-wam I have added the following test to capture the results of additional properties I have still to complete it, I will post the complete test or another complementary test as soon as possible |
|
added applied filter Knowledge-Wiki@8398d99 the test is now complete: all the new datatypes are captured except Monolingual Text (despite in the live site works). It could be related to the test config, not an error in the pull request |
…for-more-datatypes-in-filters-(3)
|
@gesinn-it-wam the error is |
|
I think I have seen a similar error in the past... not sure if we were able to fix it. Please give me some time to investigate. |
|
any news here? |
|
This does not work for me. Tried https://test.knowledge.wiki/Spezial:Daten_durchsuchen/Cities when property size is set to number, filters are showing, when set to quantity, it displays "there are nor values for this filter". |
|
@thomas-topway-it can you look into this? |
|
@thomas-topway-it can you please rebase to get the latest changes from the main branch. Now that testing is working again, we should make sure that changes are covered by testing. Ping @gesinn-it-ilm if you have any questions about tests and how to run them locally before committing. |
|
unfortunately there are conflicts, I have to use the command line for that, I will check tomorrow |
…for-more-datatypes-in-filters-(3)
|
@gesinn-it-gea done (regarding tests, should I run explicitly tests locally ? ) @gesinn-it-ilm |
|
@thomas-topway-it after rebasing, you can run the tests locally. Simply run "make ci". If you need help ping @gesinn-it-ilm . Please check, that GF does not report any conflicts. |
|
any news here, @thomas-topway-it ? |
5 participants
Adds support for all default SMW datatypes and fixes use of predefined datatypes as property label. (e.g.
[[Email::test@mail.com]], but also[[Number::123]]) --- see tables below for a precise reference between master and this pull request.adds support for the following datatypes:
The following tables show the difference between master and this pull request. Note that most of the predefined/pre-deployed data types come with a predefined special page. (see the 3rd table) . This could be taken into account for future development to fix the differences between the 2 versions.
In few cases (e.g. "record", "keyword" and "reference") master performs better using the 'page' datatype. However, based on this data, the present PR use the same datatype in these cases as a temporary solution, so it performs better than master in any case. (except possible errors to be fixed).
MASTER
PULL REQUEST