Skip to content

Fix double-encoded filter name in date range inputs #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Varlin wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

Fix double-encoded filter name in date range inputs #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion includes/Specials/BrowseData/GetApplicableFilters.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,10 @@ private function getUnappliedFilterLine( Filter $f ): string {

// For dates additionally add two datepicker inputs (Start/End) to select a custom interval.
if ( $f->propertyType() == 'date' && $possibleValues->count() != 0 ) {
$results_line .= '<br>' . $this->getDateRangeInput( $filter_name, $possibleValues->dateRange() );
# $filter_name is alread urlencoded, and getDateRangeInput applies a second urlencode()
# so this breaks the URL sent to the browser. Use a raw filter name instead.
$raw_filter_name = str_replace( ' ', '_', $f->name() );
$results_line .= '<br>' . $this->getDateRangeInput( $raw_filter_name, $possibleValues->dateRange() );
}

$text = $this->getFilterLine( $f->name(), false, $normal_filter, $results_line, $f );
Expand Down
Loading