Skip to content

gnupg: Export GnuPG binaries as shims#8257

Open
glektarssza wants to merge 3 commits into
ScoopInstaller:masterfrom
glektarssza:git-no-gpg-export
Open

gnupg: Export GnuPG binaries as shims#8257
glektarssza wants to merge 3 commits into
ScoopInstaller:masterfrom
glektarssza:git-no-gpg-export

Conversation

@glektarssza

Copy link
Copy Markdown

Do not export GnuPG binaries from Git package(s). They interfere with other GnuPG installs on the system, from Scoop or otherwise.

Instead export the appropriate binaries from the GnuPG package as shims.

The original change was made in 35e9a62 in response to #3685 which seems to be premised on an older version of the portable Git package, prior to it shipping with GnuPG 2.

As of GnuPG 2 and the latest portable Git you no longer need to export GnuPG to the system path in order to use it. If you want to use a different GnuPG install you can set the Git configuration option gpg.program and proceed from there.

See also #7459 for more context.

Will close #8256.

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

They interfere with other GnuPG installs on the system, either from Scoop or otherwise.
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

This change moves GnuPG binary exports from the git manifests to gnupg.json, removes the overlapping GPG executables from git and git-with-openssh, and adds notes in both Git manifests about using gpg.program for an alternate GnuPG installation.

Changes

GPG shim ownership migration

Layer / File(s) Summary
Add bin exports to gnupg manifest
bucket/gnupg.json
Adds a new bin array listing GnuPG executables, including agent, dirmngr, and pinentry entries, as exposed binaries.
Remove GPG bins and add override notes
bucket/git.json, bucket/git-with-openssh.json
Removes GnuPG-related executables from both Git package bin arrays and adds notes entries in each manifest describing the gpg.program configuration option.

Sequence Diagram(s)

Not applicable; these are manifest-only changes.

Related Issues: #8256
Suggested labels: manifest-update
Suggested reviewers: none identified

Poem
GnuPG shims moved to their home,
Git sheds the binaries it used to own,
A note points users to config right,
And PATH stays ordered, clean, and tight.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The changes address #8256 by exporting GnuPG binaries from gnupg and removing them from git and git-with-openssh.
Out of Scope Changes check ✅ Passed No unrelated changes are evident; the edits all support the GnuPG shim/export fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title is concise and matches the main change: exporting GnuPG binaries as shims.
Description check ✅ Passed The description includes the change summary, rationale, linked issue context, and required checklist items.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1ca5a131-5671-45be-a02b-f98363319c94

📥 Commits

Reviewing files that changed from the base of the PR and between 72b657c and b58f31c.

📒 Files selected for processing (3)
  • bucket/git-with-openssh.json
  • bucket/git.json
  • bucket/gnupg.json
💤 Files with no reviewable changes (1)
  • bucket/git-with-openssh.json

Comment thread bucket/git.json Outdated
@glektarssza

Copy link
Copy Markdown
Author

@coderabbitai

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Tip

For best results, initiate chat on the files or code changes.

@glektarssza I see you've tagged me but I don't see a specific question or request in your comment. Could you let me know what you'd like help with? For example, I could:

  • Review the changes in this PR
  • Answer questions about the GnuPG/Git binary export changes
  • Help verify the manifest changes align with the linked issue (#8256)
  • Something else entirely

Just let me know how I can help!

@glektarssza

Copy link
Copy Markdown
Author

@coderabbitai Rereview this PR.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

@glektarssza Sure, I'll re-review the PR now.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@z-Fng z-Fng changed the title [gnupg] Export GnuPG binaries as shims gnupg: Export GnuPG binaries as shims Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: gpg binaries added to PATH are overwritten by shims from Git package(s)

1 participant