gnupg: Export GnuPG binaries as shims#8257
Conversation
They interfere with other GnuPG installs on the system, either from Scoop or otherwise.
WalkthroughThis change moves GnuPG binary exports from the git manifests to gnupg.json, removes the overlapping GPG executables from git and git-with-openssh, and adds notes in both Git manifests about using ChangesGPG shim ownership migration
Sequence Diagram(s)Not applicable; these are manifest-only changes. Related Issues: #8256 Poem 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1ca5a131-5671-45be-a02b-f98363319c94
📒 Files selected for processing (3)
bucket/git-with-openssh.jsonbucket/git.jsonbucket/gnupg.json
💤 Files with no reviewable changes (1)
- bucket/git-with-openssh.json
|
Tip For best results, initiate chat on the files or code changes.
Just let me know how I can help! |
|
@coderabbitai Rereview this PR. |
|
✅ Action performedReview finished.
|
Do not export GnuPG binaries from Git package(s). They interfere with other GnuPG installs on the system, from Scoop or otherwise.
Instead export the appropriate binaries from the GnuPG package as shims.
The original change was made in 35e9a62 in response to #3685 which seems to be premised on an older version of the portable Git package, prior to it shipping with GnuPG 2.
As of GnuPG 2 and the latest portable Git you no longer need to export GnuPG to the system path in order to use it. If you want to use a different GnuPG install you can set the Git configuration option
gpg.programand proceed from there.See also #7459 for more context.
Will close #8256.
<manifest-name[@version]|chore>: <general summary of the pull request>