[AI] add static indexing for discrete/constants/nonnumeric#4632
Open
SebastianM-C wants to merge 1 commit into
Open
[AI] add static indexing for discrete/constants/nonnumeric#4632SebastianM-C wants to merge 1 commit into
SebastianM-C wants to merge 1 commit into
Conversation
This adds StaticBufferIndex to perform indexing in the type domain for the discrete/constants/nonnumeric portions. This mainly helps Enzyme's type analysis for use cases that include nonnumeric parameters, like neural networks. See SciML/SciMLSensitivity.jl#1477 for more details. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds StaticBufferIndex to perform indexing in the type domain for the discrete/constants/nonnumeric portions.
This mainly helps Enzyme's type analysis for use cases that include nonnumeric parameters, like neural networks.
I'm not sure if we would have any cases where static indexing of those portions would be unreasonable. Besides that, I mainly care about the nonnumeric case, the others were added for consistency, but I can drop that if it would create issues.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
See SciML/SciMLSensitivity.jl#1477 for more details.