Skip to content

Fix ansible lint in qe_sap_storage role - #384

Open
mpagot wants to merge 1 commit into
SUSE:mainfrom
mpagot:ansible_role_lint
Open

Fix ansible lint in qe_sap_storage role#384
mpagot wants to merge 1 commit into
SUSE:mainfrom
mpagot:ansible_role_lint

Conversation

@mpagot

@mpagot mpagot commented Aug 19, 2025

Copy link
Copy Markdown
Collaborator

Preparation for ticket: https://jira.suse.com/browse/TEAM-10423

This fix warnings like

var-naming[no-role-prefix]: Variables names from within roles should use qe_sap_storage_ as a prefix. (vars: sap_storage_az_lun)

or

fqcn[action-core]: Use FQCN for builtin module actions (include_vars).

Verification

sle-15-SP7-Qesap-Azure-Byos-x86_64-BuildLATEST_AZURE_SLE15_7_BYOS-qesap_azure_saptune_test_msi

sle-15-SP6-Qesap-Azure-Payg-x86_64-BuildLATEST_AZURE_SLE15_6_PAYG-qesap_azure_saptune_test

@mpagot
mpagot force-pushed the ansible_role_lint branch from f05ea38 to f400d50 Compare August 19, 2025 14:53
@mpagot
mpagot marked this pull request as ready for review August 20, 2025 06:58

@lpalovsky lpalovsky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarocarvajald alvarocarvajald left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants