fix(stash): exclude node_modules from buildResult stash - #5861
Open
maxcask wants to merge 1 commit into
Open
Conversation
The buildResult stash includes `**/dist/**` which matches dist/ folders inside node_modules packages, causing 100k+ unnecessary files to be stashed on projects with npm dependencies. This adds the same-class of excludes already used by checkmarx/checkmarxOne to the buildResult stash entry, preventing node_modules and other non-artifact paths from being stashed. Measured impact: 40k+ files and ~3 minutes saved per Central Build stage on affected projects (e.g. AdminUIService build #9894).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildResultstash includes**/dist/**, which matchesdist/folders insidenode_modulespackagescheckmarx/checkmarxOnetobuildResultPattern added:
Performance impact (measured on AdminUIService, build #9894)
webCore/node_modules/**/dist/**webDevOps/node_modules/**/dist/**buildResultstashpipelineStashFilesAfterBuildtotalReference build log:
https://gkecpspipeline2.jaas-gcp.cloud.sap.corp/job/CPServices/job/AdminUIService/job/dev/9894/consoleTest plan
buildResultstash no longer includesnode_modules/**/dist/**files on a project with npm dependencies.war,.jar,.mtar, and project-owneddist/artifacts are still stashed correctlynode_modulesare unaffected