Skip to content

chore(deps): clear Dependabot alerts via lockfile regen + vitest v4 bump#36

Merged
jung-thomas merged 1 commit into
mainfrom
chore/dependabot-cleanup
Jun 12, 2026
Merged

chore(deps): clear Dependabot alerts via lockfile regen + vitest v4 bump#36
jung-thomas merged 1 commit into
mainfrom
chore/dependabot-cleanup

Conversation

@jung-thomas

Copy link
Copy Markdown
Contributor

Summary

Following the OSPO-driven enablement of Dependabot security updates in #35, GitHub surfaced 64 vulnerabilities that had been silently accumulating in stale lockfiles. This PR clears the bulk of them.

What changed

Manifest Before After Action
solution/MyHANAApp/package-lock.json 6 (1🔴 2🟠 3🟡) 0 Regenerated. Upstream @sap/cds-dk dropped its axios transitive dep, eliminating the 39-alert axios chain.
solution/MyHANAApp/app/router/package-lock.json 10 (6🟠 4🟡) 2 🟠 Regenerated. Two residual axios-via-approuter alerts deferred (see below).
docs/package.json + docs/package-lock.json 17 (1🔴 6🟠 10🟡) 4 🟡 Regenerated. Bumped vitest ^2.1.9 → ^4 (semver-major) to fix the critical vitest CVE; verified all 23 unit tests still pass and npm run docs:build succeeds.
Total 33 local / 64 GH alerts 6 local Bulk regen + targeted dev-tool bump.

🔴 critical · 🟠 high · 🟡 moderate

What's left and why

2 alerts in AppRouter (axios via @sap/approuter@21)

@sap/approuter 21.x transitively pins an old axios. The fix requires @sap/approuter@22, a semver-major bump that may affect routing config. This is a workshop-content change deserving its own validated PR (re-test exercise 5/8 with the live AppRouter, confirm xs-app.json and mta.yaml destination routing). Will open a follow-up issue.

4 alerts in docs (esbuild → vite → vitepress chain)

  • esbuild GHSA-67mh-4wv8-2f99 — dev server CORS issue
  • vite path-traversal in .map handling — dev server only
  • Both flow up through vitepress and vitepress-plugin-mermaid (no fix available; vitepress 1.6.4 is latest stable).

Risk: these only manifest while running npm run docs:dev and an attacker can already reach localhost on the developer's machine. The production output of npm run docs:build (the static site we deploy) is unaffected. Will dismiss in Dependabot as tolerable risk – dev server only with a note to re-evaluate when vitepress 2.x lands.

Verification done

  • npm audit before/after captured for every manifest (numbers in the table above)
  • docs/: npm test → 23/23 passing on vitest v4
  • docs/: npm run docs:build → success, no errors
  • solution/MyHANAApp/: cds compile srv → success
  • Pre-existing ESLint errors in OPA test files (unrelated to lockfiles) confirmed by stash-and-rerun; not addressed here.

No source-code changes

Only lockfile regen and the single vitest devDependency bump. Workshop participant experience is unchanged for any exercise that uses these dependencies — they'll just install fresher transitive versions.

…abilities

Resolves the bulk of the 64 open Dependabot alerts surfaced after enabling
security updates on this repo. Three manifests were regenerated:

  solution/MyHANAApp/package-lock.json
    - npm audit: 6 -> 0 vulnerabilities (axios chain dropped by upstream)

  solution/MyHANAApp/app/router/package-lock.json
    - npm audit: 10 -> 2 vulnerabilities
    - Remaining 2 (axios via @sap/approuter@21) require a major bump to
      @sap/approuter@22; deferred to a separate validated PR since this
      could affect xs-app.json / mta.yaml routing.

  docs/package.json + docs/package-lock.json
    - vitest devDependency bumped from ^2.1.9 to ^4 (compat verified: all
      23 unit tests still pass, docs build still produces clean output)
    - npm audit: 17 -> 4 vulnerabilities
    - Remaining 4 are upstream-pending in the vitepress -> vite -> esbuild
      chain, only reachable via the local dev server (npm run docs:dev),
      not the production docs build. Will be dismissed in Dependabot with
      'tolerable risk - dev server only' until vitepress publishes a fix.

No source-code changes; only lockfiles and one devDependency major bump.
@jung-thomas jung-thomas merged commit 45941a7 into main Jun 12, 2026
1 check passed
@jung-thomas jung-thomas deleted the chore/dependabot-cleanup branch June 12, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant