Add in-app UI to set site cookies (Fix #2182)#2185
Open
bchkv wants to merge 1 commit into
Open
Conversation
Stores cookies in config-dir sidecar files with Network-tab paste instructions. Fixes JWT/JSON cookie parsing and wires Http to load per-domain cookies.
87f7f58 to
f2e2b35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Description
Adds Configuration → Site cookies... so users can paste a browser Network tab
Cookieheader without editingrip.propertiesmanually.cookies.<domain>), so saving other settings from the UI does not wipe them.cookies.<domain>entries fromrip.propertiesfor backward compatibility.Related issues:
Testing
Required verification:
gradlew test(there are no new failures or errors).Optional but recommended:
Notes:
SiteCookieStorageTestpasses. Full./gradlew testhas live-site rippper failures that also occur on cleanmain(9 failures on main vs 6 on this branch); none are introduced by the cookie changes.