Add rc.let custom operator - #7506
Draft
ajpallares wants to merge 11 commits into
Draft
Conversation
Binds names that survive iteration, so a nested predicate can compare an item against a value from the enclosing level. var reads the active data first and falls back to bindings, leaving predicates without an rc.let resolving exactly as before. Co-authored-by: Cursor <cursoragent@cursor.com>
…ine-rc-let Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # Tests/UnitTests/RulesEngine/PredicateFixtureTests.swift
…ine-rc-let Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # Tests/UnitTests/RulesEngine/PredicateFixtureTests.swift
…ine-rc-let Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # Tests/UnitTests/RulesEngine/PredicateFixtureTests.swift
…ine-rc-let Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # Tests/UnitTests/RulesEngine/PredicateFixtureTests.swift
…ine-rc-let Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # Tests/UnitTests/RulesEngine/PredicateFixtureTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-androidand hybridsMotivation
Iteration replaces the whole scope with the current item, so a predicate inside
someorreducecannot reach a value from the enclosing level, which is what ranking, deduplication and "this item versus the others" all need.rc.rootVaronly reaches the root, not intermediate levels.Description
{"rc.let": [{"name": expression, ...}, body]}evaluatesbodywith each name available tovar, and the names survive scope rebinding.varreads the active data first, bindings second. A binding therefore cannot mask a field the data has, and any predicate without anrc.letaround it resolves exactly as before, includingmissing, which agrees withvaron what exists.rc.letto chain them...