Skip to content

Remove unused background.jpg asset from RevenueCatUI - #7489

Merged
MonikaMateska merged 3 commits into
mainfrom
monika/remove-unused-asset-from-RevenueCatUI
Aug 25, 2026
Merged

Remove unused background.jpg asset from RevenueCatUI#7489
MonikaMateska merged 3 commits into
mainfrom
monika/remove-unused-asset-from-RevenueCatUI

Conversation

@MonikaMateska

@MonikaMateska MonikaMateska commented Aug 24, 2026

Copy link
Copy Markdown
Member

Checklist

  • If applicable, unit tests
  • If applicable, create follow-up issues for purchases-android and hybrids

Motivation

We have a 106 KB background.jpg that can no longer reach the screen: it's only referenced as the legacy default paywall's images.background, and every path that builds that paywall now renders DefaultPaywallView instead.

Resolves PWENG-220.

Description

background.jpg could previously be reached through a few different paths, but none of them actually display it anymore:

  • The default paywall paths always fall back to the standard default paywall, which uses its own imageset instead
  • The Paywalls V2 footer fallback can still render Template 2, but footer layouts don’t display a background image
  • The loading paywall was the only place that could still read the background image directly, but that view is no longer used in production. The current loading state uses the default paywall instead. The old loading view now only shows up in snapshot tests and renders with a plain background

Note

Low Risk
Asset and fallback-paywall cleanup with no purchase or auth changes; visible impact is limited to legacy loading/snapshot paths and slightly smaller RevenueCatUI bundles.

Overview
Removes the legacy background.jpg bundle asset (~106 KB) and stops wiring it into default fallback paywall configuration, since production paths no longer display it.

Packaging drops background.jpg from SPM (Package.swift, Package@swift-5.8.swift), CocoaPods (RevenueCatUI.podspec), and the Xcode project. PaywallData.createDefault no longer sets images.background or the backgroundImage constant. LoadingPaywallView uses the standard default paywall only and drops the blurred TemplateBackgroundImageView background plus the paywall variant that cleared the background for shimmer.

Tests update PaywallData validation JSON snapshots so default paywalls expect "background": null, and ImageLoaderTests loads sample image bytes via .withLocalImages instead of the removed default background URL.

Reviewed by Cursor Bugbot for commit c8aa6b7. Bugbot is set up for automated code reviews on this repo. Configure here.

@MonikaMateska
MonikaMateska requested review from a team as code owners August 24, 2026 14:05
@MonikaMateska
MonikaMateska requested a review from a team as a code owner August 24, 2026 14:05
@emerge-tools

emerge-tools Bot commented Aug 24, 2026

Copy link
Copy Markdown

4 builds decreased size

Name Version Download Change Install Change Approval
RevenueCat
com.revenuecat.PaywallsTester
1.0 (1) 20.1 MB ⬇️ 104.1 kB (-0.52%) 73.2 MB ⬇️ 115.2 kB (-0.16%) N/A
BinarySizeTest
com.revenuecat.binary-size-test.local-source
1.0 (1) 4.8 MB ⬇️ 363 B 14.3 MB ⬇️ 24 B N/A
BinarySizeTest
com.revenuecat.binary-size-test.cocoapods
1.0 (1) 7.1 MB ⬇️ 104.5 kB (-1.44%) 31.3 MB ⬇️ 108.3 kB (-0.35%) ⏳ Needs approval
BinarySizeTest
com.revenuecat.binary-size-test.spm
1.0 (1) 4.8 MB ⬇️ 103.6 kB (-2.11%) 12.4 MB ⬇️ 108.3 kB (-0.87%) ⏳ Needs approval

RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 115.2 kB (-0.16%)
Total download size change: ⬇️ 104.1 kB (-0.52%)

Largest size changes

Item Install Size Change
🗑 background.jpg ⬇️ -106.5 kB
DYLD.String Table ⬇️ -3.2 kB
Other ⬇️ -5.5 kB
View Treemap

Image of diff

BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.local-source

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬇️ 24 B
Total download size change: ⬇️ 363 B

Largest size changes

Item Install Size Change
Other ⬇️ -24 B
View Treemap

Image of diff

BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.cocoapods

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬇️ 108.3 kB (-0.35%)
Total download size change: ⬇️ 104.5 kB (-1.44%)

Largest size changes

Item Install Size Change
🗑 background.jpg ⬇️ -106.5 kB
Other ⬇️ -1.8 kB
View Treemap

Image of diff

BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.spm

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬇️ 108.3 kB (-0.87%)
Total download size change: ⬇️ 103.6 kB (-2.11%)

Largest size changes

Item Install Size Change
🗑 background.jpg ⬇️ -106.5 kB
Other ⬇️ -1.8 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

@emerge-tools

emerge-tools Bot commented Aug 24, 2026

Copy link
Copy Markdown

📸 Snapshot Test

4 modified, 270 unchanged

Name Added Removed Modified Renamed Unchanged Errored Approval
RevenueCat
com.revenuecat.PaywallsTester
0 0 4 0 270 0 ⏳ Needs approval

🛸 Powered by Emerge Tools

@JZDesign JZDesign left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@MonikaMateska
MonikaMateska enabled auto-merge (squash) August 24, 2026 14:29

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1f2045c. Configure here.

Comment thread Tests/RevenueCatUITests/ImageLoaderTests.swift
@MonikaMateska
MonikaMateska merged commit dfdc6bc into main Aug 25, 2026
46 checks passed
@MonikaMateska
MonikaMateska deleted the monika/remove-unused-asset-from-RevenueCatUI branch August 25, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants