Revert Customer Center hasActiveSubscription fix (accidentally merged in #6640) - #6677
Merged
Conversation
Reverts the change to SubscriptionDetailViewModel.hasActiveSubscription and its associated tests that were squash-merged into #6640. This restores the original !subscriptionsSection.isEmpty check and the original test setup. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
facumenzella
added
pr:fix
vegaro
approved these changes
Apr 23, 2026
📸 Snapshot TestBase build not foundNo build was found for the base commit e37356e. This is required to generate a snapshot diff for your pull request. It's possible that you created a branch off the base commit before all of the CI steps have finished processing, e.g. the one that uploads a build to our system. If that's the case, no problem! Just wait and this will eventually resolve. 🛸 Powered by Emerge Tools |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SubscriptionDetailViewModel.hasActiveSubscriptionfix and its associated tests that were accidentally squash-merged into Add workflow-based paywall resolution for multipage paywalls #6640hasActiveSubscriptionto the original!customerInfoViewModel.subscriptionsSection.isEmptycheckSubscriptionDetailViewModelTestsThe changes from #6674 ended up squashed into #6640 and need to be reverted so they can land separately and deliberately.
Test plan
SubscriptionDetailViewModelTestspass with the reverted logicNote
Low Risk
Low risk revert that only changes the boolean used to classify customers as active vs not active in the Customer Center and updates the corresponding unit tests; main risk is behavior change for users with only expired subscriptions in
subscriptionsSection.Overview
Restores
SubscriptionDetailViewModel.hasActiveSubscriptionto treat any non-emptysubscriptionsSectionas "active" (no longer checkingisExpired).Updates
SubscriptionDetailViewModelTeststo remove coverage for the reverted expired-subscription behavior and to set up "no active subscription" cases using an emptysubscriptionsSection(adjusting related support-ticket visibility expectations accordingly).Reviewed by Cursor Bugbot for commit c0fff23. Bugbot is set up for automated code reviews on this repo. Configure here.