Add support template types#218
Open
WyriHaximus wants to merge 1 commit into
Open
Conversation
WyriHaximus
force-pushed
the
template-types
branch
11 times, most recently
from
November 27, 2023 22:51
022ee96 to
006cb2a
Compare
WyriHaximus
added a commit
to WyriHaximus/reactphp-awaitable-observable
that referenced
this pull request
Nov 30, 2023
Requires: ReactiveX/RxPHP#218
WyriHaximus
force-pushed
the
template-types
branch
3 times, most recently
from
December 2, 2023 18:40
9c0ae45 to
63ee9a6
Compare
WyriHaximus
marked this pull request as ready for review
December 2, 2023 18:44
WyriHaximus
commented
Dec 2, 2023
|
|
||
| paths: | ||
| - src/ | ||
| - test/types/ |
Contributor
Author
There was a problem hiding this comment.
Didn't widen this to include the entire test directory because that would add 1752 errors to solve. This PR alone was already almost 1K.
WyriHaximus
force-pushed
the
template-types
branch
from
December 2, 2023 18:54
63ee9a6 to
973a382
Compare
WyriHaximus
commented
Dec 2, 2023
WyriHaximus
force-pushed
the
template-types
branch
2 times, most recently
from
December 2, 2023 20:29
e0d57b2 to
af34b8d
Compare
WyriHaximus
changed the title
Contributor
Author
|
@davidwdan && @mbonneau This covers the basics ( 😅 ) and is ready for review. Is there anything you want me to add in the |
WyriHaximus
added a commit
to WyriHaximus/reactphp-awaitable-observable
that referenced
this pull request
Dec 3, 2023
Requires: ReactiveX/RxPHP#218
WyriHaximus
added a commit
to WyriHaximus/reactphp-awaitable-observable
that referenced
this pull request
Dec 3, 2023
Requires: ReactiveX/RxPHP#218
Contributor
Author
|
The first package update was successful based on this branch: |
WyriHaximus
added a commit
to WyriHaximus/reactphp-awaitable-observable
that referenced
this pull request
Dec 13, 2023
Requires: ReactiveX/RxPHP#218
WyriHaximus
added a commit
to WyriHaximus/reactphp-awaitable-observable
that referenced
this pull request
Feb 27, 2026
Requires: ReactiveX/RxPHP#218
WyriHaximus
added a commit
to WyriHaximus/reactphp-awaitable-observable
that referenced
this pull request
Feb 27, 2026
Requires: ReactiveX/RxPHP#218
WyriHaximus
force-pushed
the
template-types
branch
from
July 18, 2026 20:11
af34b8d to
71c425e
Compare
* Add template types, making observables usable as generics * Introduce PHPStan (v2) * Added type tests under `tests/types/` * Run PHPStan at `max` level and resolved all issues found
WyriHaximus
force-pushed
the
template-types
branch
from
July 18, 2026 21:18
71c425e to
02173c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #217
tests/types/maxlevel and resolved all issues found