Skip to content

ENH: Support CUDA ray cast projectors with parallel geometry#966

Open
axel-grc wants to merge 1 commit into
RTKConsortium:mainfrom
axel-grc:ParallelGeometry
Open

ENH: Support CUDA ray cast projectors with parallel geometry#966
axel-grc wants to merge 1 commit into
RTKConsortium:mainfrom
axel-grc:ParallelGeometry

Conversation

@axel-grc

Copy link
Copy Markdown
Collaborator

Remove the parallel-geometry rejection from CUDA ray cast forward, warped forward, and back projectors. Add parallel ray construction using the geometry projection direction, and cover it in the CUDA ray-cast adjoint test.
Also align the source-position buffer type and size with the CUDA float3 layout, removing an unsafe double-pointer cast.

Close #929

@SimonRit

Copy link
Copy Markdown
Collaborator

Please add a large test for cone-beam to see if this modification has a computational cost. If it does, move the condition out of the kernel (make two kernels).

@SimonRit

Copy link
Copy Markdown
Collaborator

Please add a test in rtkforwardprojectiontest.cxx for the parallel geometry and flat panel detector

Remove the parallel-geometry rejection from CUDA ray cast forward,
warped forward, and back projectors. Add parallel ray construction
using the geometry projection direction, and cover it in the cudaraycastadjointoperatortest and rtkforwardprojectiontest.
@axel-grc

Copy link
Copy Markdown
Collaborator Author

I made some test on cone beam before and after this PR, and it seems there is no computational cost @SimonRit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement CudaRayCast for parallel geometries

2 participants