Skip to content

fix(ci): Add -fno-gpu-sanitize flag to HOST_ASAN builds - #7164

Draft
estewart08 wants to merge 1 commit into
mainfrom
users/estewart/host-asan-fno-gpu-sanitize
Draft

fix(ci): Add -fno-gpu-sanitize flag to HOST_ASAN builds#7164
estewart08 wants to merge 1 commit into
mainfrom
users/estewart/host-asan-fno-gpu-sanitize

Conversation

@estewart08

Copy link
Copy Markdown
Contributor

Recently HOST_ASAN is default for Multi-Arch CI to improve efficiency: (#7110)

There is an issue with HOST_ASAN Multi-Arch CI. MIOpen uses -Werror and during HOST_ASAN this reports a warning that -fsanitize=address is not supported unless xnack+ is appended to the gfx target. Regular ASAN builds override the gfx942 target with gfx942:xnack+ and do not see this issue.

-fno-gpu-sanitize is used to explicitly disable sanitizer checks for GPU device target compilations, but allows host sanitization to remain.

Motivation

Unblock sanitizer build.

@geomin12 geomin12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@estewart08
estewart08 marked this pull request as ready for review August 6, 2026 21:08
@therock-pr-bot

therock-pr-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
JIRA ID : TESTAUTO-6039
JIRA ID - #330
JIRA ID #330
JIRA ID (on separate line)
ROCM-25757
ISSUE ID : TESTUTO-3334
ISSUE ID #3334
ISSUE ID - TESTAUTO-3433
ISSUE ID (on separate line)
AIRUNTIME-2352
ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
Closes #10
Fixes octo-org/octo-repo#100
Resolves: #123
#123
https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Aug 6, 2026
@therock-pr-bot

therock-pr-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@geomin12 geomin12 added the ci:host-asan Opt-in to running multi-arch host-asan CI on a pull request label Aug 7, 2026
@estewart08
estewart08 force-pushed the users/estewart/host-asan-fno-gpu-sanitize branch 2 times, most recently from 5048fe9 to ccd89ad Compare August 10, 2026 22:59
@estewart08
estewart08 marked this pull request as draft August 11, 2026 14:24
@estewart08

Copy link
Copy Markdown
Contributor Author

There is an issue with -fno-gpu-sanitize where the Driver is dropping include entries (-I) looking at another fix/workaround.

Recently HOST_ASAN is default for Multi-Arch CI to improve efficiency:
(#7110)

There is an issue with HOST_ASAN Multi-Arch CI. MIOpen uses -Werror and during HOST_ASAN
this reports a warning that -fsanitize=address is not supported unless xnack+ is
appended to the gfx target. Regular ASAN builds override the gfx942 target with
gfx942:xnack+ and do not see this issue.

-fno-gpu-sanitize is used to explicitly disable sanitizer checks for GPU device target
compilations, but allows host sanitization to remain. This option currently removes
driver arguments, which I believe to be a bug. Instead -Xarch_host is used to separate
host only sanitizer flags.
@estewart08
estewart08 force-pushed the users/estewart/host-asan-fno-gpu-sanitize branch from ccd89ad to 196e441 Compare August 11, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:host-asan Opt-in to running multi-arch host-asan CI on a pull request Not ready to Review PR has unresolved policy failures — reviews blocked

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

2 participants