Skip to content

Set rmw_zenoh as the Default ROS 2 Middleware#373

Merged
GyuH13 merged 3 commits into
mainfrom
feature-zenoh
Jun 26, 2026
Merged

Set rmw_zenoh as the Default ROS 2 Middleware#373
GyuH13 merged 3 commits into
mainfrom
feature-zenoh

Conversation

@sunghowoo

Copy link
Copy Markdown
Member
  • Updated dockerfile to use zenoh-cpp
  • Updated SRDF for OMY-F3M

Signed-off-by: Sungho Woo <wsh@robotis.com>
Signed-off-by: Sungho Woo <wsh@robotis.com>
@sunghowoo sunghowoo added the enhancement New feature or request label Jun 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the OpenMANIPULATOR packages to version 5.0.0, configures the Docker environment to use Zenoh-cpp, adds several bash aliases, and updates the SRDF configuration for the OMX-F manipulator to disable collisions between link6 and link7. The feedback recommends defining the ROS_DOMAIN_ID and RMW_IMPLEMENTATION environment variables using the ENV instruction in the Dockerfile instead of appending them to .bashrc, ensuring they are correctly set for non-interactive shells.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread docker/Dockerfile
- Implemented functions to fetch the current version from the meta package and the latest version from GitHub releases.
- Added notifications for available updates when starting or entering the container.
- Included a notice regarding the default RMW implementation since version 5.0.0.

Signed-off-by: Sungho Woo <wsh@robotis.com>
Comment thread docker/docker-compose.yml
Comment thread docker/Dockerfile
Comment thread docker/docker-compose.yml

@kimtaehyeong99 kimtaehyeong99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GyuH13 GyuH13 merged commit 26807fc into main Jun 26, 2026
9 checks passed
@GyuH13 GyuH13 deleted the feature-zenoh branch June 26, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants