Skip to content

Remove bp-wallet dependency - #308

Merged
dr-orlovsky merged 32 commits into
masterfrom
develop
Jul 15, 2025
Merged

Remove bp-wallet dependency#308
dr-orlovsky merged 32 commits into
masterfrom
develop

Conversation

@dr-orlovsky

Copy link
Copy Markdown
Member

In style of RGB-WG/rgb-std#323 this PR rethinks what underlying wallet should do for RGB needs; simplifying these requirements as much as possible. This allows to remove bp-wallet dependency and use much simpler persistence and resolver APIs.

@codecov

codecov Bot commented Jul 8, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 9.24370% with 432 lines in your changes missing coverage. Please review.

Project coverage is 5.7%. Comparing base (b6b927c) to head (f81d0f8).
Report is 33 commits behind head on master.

Files with missing lines Patch % Lines
src/owner.rs 18.5% 189 Missing ⚠️
src/resolvers/mod.rs 0.0% 69 Missing ⚠️
src/resolvers/electrum.rs 0.0% 61 Missing ⚠️
src/resolvers/esplora.rs 0.0% 57 Missing ⚠️
src/runtime.rs 0.0% 24 Missing ⚠️
cli/src/args.rs 0.0% 14 Missing ⚠️
cli/src/opts.rs 0.0% 8 Missing ⚠️
cli/src/exec.rs 0.0% 6 Missing ⚠️
src/descriptor.rs 20.0% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #308     +/-   ##
=======================================
+ Coverage     3.8%   5.7%   +1.9%     
=======================================
  Files          10     13      +3     
  Lines        1063   1409    +346     
=======================================
+ Hits           40     80     +40     
- Misses       1023   1329    +306     
Flag Coverage Δ
rust 5.7% <9.2%> (+1.9%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dr-orlovsky
dr-orlovsky marked this pull request as ready for review July 9, 2025 08:21
Async support for wallet and witness syncrhonization
@dr-orlovsky
dr-orlovsky merged commit d0e8d17 into master Jul 15, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant