Bump sea-orm to 1.1.19 and change async runtime to tokio#67
Conversation
zoedberg
left a comment
zoedberg
left a comment
There was a problem hiding this comment.
This PR is incomplete, all sea-orm crates should be bumped, entity files should be regenerated as explained in https://github.com/RGB-Tools/rgb-lib/blob/master/migration/README.md and the async runtime should be changed also in the migration crate.
Anyway, currently rgb-lib is under massive changes, which involved also the bump of sea-orm. I will update you when you can rebase this PR.
dcorral
force-pushed
the
bump-sea-orm-tokio-runtime
branch
from
a604103 to
945848b
Compare
dcorral
force-pushed
the
bump-sea-orm-tokio-runtime
branch
4 times, most recently
from
d68cd67 to
f04652e
Compare
zoedberg
left a comment
zoedberg
left a comment
There was a problem hiding this comment.
Please drop the tokio features if actually unneeded, address the suggested changes and then rebase on top of the latest master tip keeping a single signed commit.
dcorral
force-pushed
the
bump-sea-orm-tokio-runtime
branch
2 times, most recently
from
294237b to
3384536
Compare
|
@zoedberg thanks for the review, all comments have been addressed and the branch is up to date with master. Please double check. Let me know if there is any other change required. 🙏 |
dcorral
force-pushed
the
bump-sea-orm-tokio-runtime
branch
from
3384536 to
eed5248
Compare
zoedberg
left a comment
zoedberg
left a comment
There was a problem hiding this comment.
There are still some messy imports, please check the requested changes. Also the lint job is failing because you didn't generate the lock files for the bindings, run (cd ./bindings/c-ffi && cargo clippy) and (cd ./bindings/uniffi && cargo clippy) to fix those please
dcorral
force-pushed
the
bump-sea-orm-tokio-runtime
branch
from
eed5248 to
4437917
Compare
2 participants
This PR bumps sea-orm version from 1.1.12 to 1.1.19 and also changes async runtime from async-std (deprecated) to tokio