fix: Revised generation of UniqueID within goFlux function - #39
Merged
Conversation
If UniqueID is missing from the input data, generate UniqueID by combining chambID with the date part of start.time instead of with DATE to prevent measurements that extend over midnight from being split into two different UniqueIDs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UniqueID in the goFlux function is now generated by combining chamberID with the date information from the start.time instead of from the DATE column. Because start.time remains constant throughout a measurement this avoids that measurements that extend beyond midnight are split into two different UniqueIDs (because of DATE changing at midnight).