Add setting for Illusioners in raids. by Mickey42302 · Pull Request #1819 · PurpurMC/Purpur

Mickey42302 · 2026-08-04T03:42:50Z

I'd like to suggest adding a "spawn-in-raids" setting for Illusioners. Having these mobs as a part of raids would add a nice challenge.

By default, the feature is disabled. However, players can opt in by changing it to "true" in the "purpur.yml" file.

kacimiamine

While I can't look into the code right now to check the implementation, you can for now include // Purpur comments and also I don't see why we need a variable there ?

kacimiamine · 2026-08-04T05:25:49Z

+     private Raid.RaidStatus status;
+     private int celebrationTicks;
+     private Optional<BlockPos> waveSpawnPos = Optional.empty();
+    public boolean includeIllusioners;


Why the need of a variable when you can just use the config directly ? This is unnecessary

kacimiamine · 2026-08-04T05:26:53Z

+                     } else if (groupNumber >= this.getNumGroups(Difficulty.HARD)) {
+                         if (ravagersSpawned == 0) {
+-                            ridingRaider = EntityTypes.EVOKER.create(level, EntitySpawnReason.EVENT);
+                            if (level.purpurConfig.illusionerSpawnInRaids) {


Diff like this should start with // Purpur start comment and end with // Purpur end

kacimiamine · 2026-08-04T05:27:14Z

+                                    : EntityTypes.ILLUSIONER.create(level, EntitySpawnReason.EVENT);
+                            } else {
+                                ridingRaider = EntityTypes.EVOKER.create(level, EntitySpawnReason.EVENT);
+                            }


// Purpur end should be after this

kacimiamine · 2026-08-04T05:27:30Z

+         int bonusSpawns;
+         switch (type) {
+             case VINDICATOR:
+            case ILLUSIONER:


// Purpur comment

kacimiamine · 2026-08-04T05:27:41Z

+         VINDICATOR(EntityTypes.VINDICATOR, new int[]{0, 0, 2, 0, 1, 4, 2, 5}),
+         EVOKER(EntityTypes.EVOKER, new int[]{0, 0, 0, 0, 0, 1, 1, 2}),
+         PILLAGER(EntityTypes.PILLAGER, new int[]{0, 4, 3, 3, 4, 4, 4, 2}),
+        ILLUSIONER(EntityTypes.ILLUSIONER, new int[]{0, 0, 1, 0, 1, 1, 0, 1}),


// Purpur comment

kacimiamine · 2026-08-04T05:33:27Z

As a side note, I recommend you check the CONTRIBUTING file and granny's comment on the last PR, as it can help you in future contributions (You can also check other merged PRs how they are done)

Mickey42302 · 2026-08-04T13:56:24Z

I've added the missing comments.

I created the "includeIllusioners" variable as a workaround since the original approach kept giving me errors. The code still works as intended with the variable, though.

BillyGalbreath · 2026-08-04T14:07:21Z

I created the "includeIllusioners" variable as a workaround since the original approach kept giving me errors. The code still works as intended with the variable, though.

What errors? This variable is 100% unnecessary. We should look into those issues instead of working around them like that.

kacimiamine · 2026-08-04T14:11:11Z

I just applied your patch and removed that variable and I got no errors. As Billy said, what kind of issues are you encountering?

And those comments are confusing, they should describe exactly the feature as stated in here e.g.

// Purpur - Ability for illusioners to spawn during raids

Mickey42302 · 2026-08-04T15:08:11Z

Turns out it was an issue with the cache. Derp.

Do you want "// Purpur - Ability for Illusioners to spawn during raids" to be in all spots for the Illusioner code?

kacimiamine · 2026-08-04T15:14:20Z

It looks you sent the patch to your other PR instead of this. Why are you using the GitHub UI instead of git commands?

I really suggest you join the discord and talk there about features and issues you might encounter, as these feel like redundant reviews across PRs which we're happy to help you on how to maintain better code

Mickey42302 · 2026-08-04T15:25:24Z

I use the UI because it's what I'm used to. I'm already in the Discord too. I have the same username: Mickey42302.

I guess I'll be more transparent about the next idea I'm planning to work on. This one will probably require more complex code.

kacimiamine · 2026-08-04T15:46:42Z

Understanding the basics of git and its commands will simplify a lot of work, especially when handling such PRs e.g. instead of uploading one file per commit, you can add all of them in one meaningful commit, anyway a bit off-topic.

And yes, best discussing ideas in discord and especially if you feel the implementation is complex or the comments look confusing. There will people willing to help on that, so better talk therefore any issues you have (even this one you can share it there), this should avoid the redundant reviews and make it easier

BillyGalbreath

everything looks good as-is. this is just my personal nit-pick. feel free to disregard if you want :)

BillyGalbreath · 2026-08-04T15:30:18Z

+                     Raider ridingRaider = null;
+                     if (groupNumber == this.getNumGroups(Difficulty.NORMAL)) {
+                         ridingRaider = EntityTypes.PILLAGER.create(level, EntitySpawnReason.EVENT);
+                        // Purpur start - use the setting to determine if Ravagers with Illusioners should spawn


it looks like this should be moved two lines down

BillyGalbreath · 2026-08-04T15:31:34Z

+         boolean isBonusGroup = this.shouldSpawnBonusGroup();
+
+         for (Raid.RaiderType raiderType : Raid.RaiderType.VALUES) {
+            // Purpur start - exclude Illusioners if the feature is disabled


you can collapse all this into a single line to minimize the diff

BillyGalbreath · 2026-08-04T15:33:10Z

+-                            ridingRaider = EntityTypes.EVOKER.create(level, EntitySpawnReason.EVENT);
+                            if (level.purpurConfig.illusionerSpawnInRaids) {
+                                ridingRaider = random.nextBoolean()
+                                    ? EntityTypes.EVOKER.create(level, EntitySpawnReason.EVENT)


idk how i feel about a ternary operator spreading across multiple lines. if it's for readability might as well just use a standard if/else with proper brackets.

+ if (level.purpurConfig.illusionerSpawnInRaids) { + if (random.nextBoolean()) { + ridingRaider = EntityTypes.ILLUSIONER.create(level, EntitySpawnReason.EVENT); + } else { + ridingRaider = EntityTypes.EVOKER.create(level, EntitySpawnReason.EVENT); + } + } else { + ridingRaider = EntityTypes.EVOKER.create(level, EntitySpawnReason.EVENT); + }

but that still looks very busy, especially with repeat code.

personally, i would shorten the code a little more by combining the two conditions required for the illusioner to spawn. here's all those lines merged into a one-liner that is easier to read, imo.

ridingRaider = (level.purpurConfig.illusionerSpawnInRaids && random.nextBoolean() ? EntityTypes.ILLUSIONER : EntityTypes.EVOKER).create(level, EntitySpawnReason.EVENT); // Purpur

Mickey42302 · 2026-08-04T18:11:00Z

The changes are applied now.

Mickey42302 added 2 commits August 3, 2026 23:39

Add illusionerSpawnInRaids configuration option

b679dce

Add files via upload

00a2663

kacimiamine reviewed Aug 4, 2026

View reviewed changes

Add files via upload

e7e0936

Add files via upload

d874ddc

Add files via upload

83d6f56

BillyGalbreath reviewed Aug 4, 2026

View reviewed changes

Update Raid.java.patch

d7eb20a

Update Raid.java.patch

4dd41c0

BillyGalbreath approved these changes Aug 5, 2026

View reviewed changes

Uh oh!

Uh oh!

Conversation

Mickey42302 commented Aug 4, 2026

Uh oh!

kacimiamine left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kacimiamine commented Aug 4, 2026

Uh oh!

Mickey42302 commented Aug 4, 2026

Uh oh!

BillyGalbreath commented Aug 4, 2026

Uh oh!

kacimiamine commented Aug 4, 2026

Uh oh!

Mickey42302 commented Aug 4, 2026

Uh oh!

kacimiamine commented Aug 4, 2026

Uh oh!

Mickey42302 commented Aug 4, 2026

Uh oh!

kacimiamine commented Aug 4, 2026

Uh oh!

BillyGalbreath left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mickey42302 commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants