Skip to content

feature: AWS Architect adapter - #8

Draft
thescientist13 wants to merge 19 commits into
mainfrom
feature/arc-adapter
Draft

feature: AWS Architect adapter#8
thescientist13 wants to merge 19 commits into
mainfrom
feature/arc-adapter

Conversation

@thescientist13

@thescientist13 thescientist13 commented Feb 21, 2025

Copy link
Copy Markdown
Member

ProjectEvergreen/greenwood#1142

Summary

  1. AWS adapter with Architect - https://y9ytogm4l7.execute-api.us-east-1.amazonaws.com/

See another demo implementation here - AnalogStudiosRI/api#44)

TODO

  1. SSR pages (can't end route with /?
    • still seems to work as /product, but then breaks in app because of <a> tags)
    sandbox failed! Validation error:
    - Invalid @http path (cannot end with '/'): get /products/
    Error: Validation error:
    - Invalid @http path (cannot end with '/'): get /products/
        at format (/Users/owenbuckley/Workspace/project-evergreen/greenwood-demo-adapter-aws/node_modules/@architect/inventory/src/lib/error-fmt.js:15:13)
        at /Users/owenbuckley/Workspace/project-evergreen/greenwood-demo-adapter-aws/node_modules/@architect/inventory/src/index.js:92:18
        at process.processTicksAndRejections (node:internal/process/task_queues:90:21)
  2. latest runtime
  3. dynamic / wildcard method
  4. Final plugin implementation - AWS Adapter plugin greenwood#1142
  5. request.json usage is not working - request.json not working in API Routes with current AWS based adapter plugins (AWS, Netlify) greenwood#1460
  6. (nice to have) Nested API routes (and pages?) not working - [Arc] Nested API routes and SSR pages #10
  7. this warning
    ⚠️ Warning: Lambda treeshaking does not support dynamic imports, dependency may not be installed: /Users/owenbuckley/Workspace/project-evergreen/greenwood-demo-adapter-aws/.aws-output/routes/products imports 'moduleUrl'
  8. README updates (Admin / webhook page, Arc, etc)
  9. Production deployment GitHub action

Thoughts / Questions (Arc Preset)

  1. not really a nice / clean way to programmatically generate a app.arc file, is there? - Presets for AWS Adapter Plugin greenwood#1430
    • or is there an @import kind of thing?
    • javascript config file?
    • handle basePath
  2. wild card method instead of having to specify GET / POST / etc - can use any
  3. had to use /* to handle SSR pages routes, since @http can't end in /, not sure if it's the best?
  4. Does Architect support Cloudfront / Route 53? - No, its manual it seems - https://arc.codes/docs/en/guides/domains/registrars/route53-and-cloudfront
  5. Looks like Architect will automatically upload your public folder if you are using @http
    • not sure if there's a way to disable that? Just delete the directory manually?

@thescientist13 thescientist13 added documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested needs upstream labels Feb 21, 2025
@thescientist13 thescientist13 self-assigned this Feb 21, 2025
@thescientist13 thescientist13 changed the title feature/AWS Arc adapter feature/AWS Architect adapter Feb 21, 2025
@thescientist13 thescientist13 removed question Further information is requested needs upstream labels Mar 2, 2025
@thescientist13 thescientist13 changed the title feature/AWS Architect adapter feature: AWS Architect adapter Sep 13, 2025
@thescientist13
thescientist13 marked this pull request as ready for review September 13, 2025 18:39
@thescientist13
thescientist13 marked this pull request as draft September 13, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Architect documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant