Skip to content

Add Bug type and example_ws label to weekly failure issue#730

Merged
JWhitleyWork merged 1 commit into
mainfrom
claude/weekly-failure-issue-bug-type
Jun 22, 2026
Merged

Add Bug type and example_ws label to weekly failure issue#730
JWhitleyWork merged 1 commit into
mainfrom
claude/weekly-failure-issue-bug-type

Conversation

@shaur-k

@shaur-k shaur-k commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

What

The weekly-failure-issue job (from #721) files a GitHub issue on PickNikRobotics/moveit_pro when the weekly sim integration suite fails. This tags that issue with:

  • the native Bug issue Type (org-level field moveit_pro triages by), and
  • the example_ws label (marks repo-of-origin in moveit_pro's shared tracker).

Both verified to exist in moveit_pro. The same type: "Bug" pattern is already used by moveit_pro's own e2e-nightly.yaml / benchmarks-nightly.yaml.

Fail-open

type/labels are applied best-effort: the issues.create call is wrapped so that if it rejects them (e.g. the "Bug" type is later renamed), it retries with just title/body. The failure notification must always land — same fail-open intent as the dedupe search above it. Without the wrap, a rejected type would throw and silently drop the notification.

Reviewed

  • code-reviewer + platform-architect-bot. The architect's blocker (unwrapped create dropping the notification) is fixed by the retry above.

Notes for the reviewer

  • App grant: this relies on the SISTER_REPOS GitHub App installation having Issues: write on moveit_pro. That's a different grant than the commit-status write the integration-status job uses, so it hasn't been exercised yet — please confirm the installation has it (if not, even the bare retry create fails). The weekly cron hasn't fired, so this path is still unrun.
  • The comment-on-existing-issue branch does not retroactively apply the Type/label — a recurring issue opened before this change keeps its original (untyped) state. Intended.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The CI workflow's weekly-failure-issue job is updated so that GitHub issue creation is fail-open: it first attempts to create the issue with type: 'Bug' and labels: ['example_ws'], and on HTTP 422 error retries with only owner, repo, title, and body.

Changes

CI Weekly Failure Notification

Layer / File(s) Summary
Fail-open issue creation with type/labels retry
.github/workflows/ci.yaml
Issue creation is wrapped in a try/catch: the primary attempt includes type: 'Bug' and labels: ['example_ws']; on a 422 error, a fallback create is made with only owner, repo, title, and body, ensuring the notification is posted even when type or label application fails.

🔕 Pre-merge checks override applied

The pre-merge checks have been overridden successfully. You can now proceed with the merge.

Overridden by @JWhitleyWork via checkbox on 2026-06-22T17:45:38.608Z.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Human Review Check ❌ Error [IGNORED] PR modifies CI/CD workflow with authentication (GitHub App secrets) and requires cross-repo permissions—both high-risk areas requiring human review. This PR requires review by a requested human reviewer. After review, a non-author requested reviewer should override this pre-merge check.
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains the changes made to the weekly-failure-issue job, including the addition of Bug type and example_ws label, and the fail-open retry logic.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown

⚠️ This PR modifies 1 file(s) that also exist in PickNikRobotics/moveit_pro_empty_ws.

Consider whether the change should land upstream in moveit_pro_empty_ws first so downstream forks pick it up on the next sync.

Overlapping files
  • .github/workflows/ci.yaml

@shaur-k shaur-k marked this pull request as ready for review June 22, 2026 14:34

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ci.yaml:
- Around line 424-434: The catch block currently handles all errors the same way
by retrying the issues.create call without type/labels, which can cause
duplicate issues if the first create succeeded remotely but the response failed
locally. Modify the catch block to check if the error is specifically a
validation error (HTTP 422 status code) related to type or labels rejection, and
only then retry the issues.create call without those fields. For all other error
types, rethrow the exception instead of blindly retrying.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 42ec6368-812a-4509-82db-efdcd836280a

📥 Commits

Reviewing files that changed from the base of the PR and between 992d79c and cec81c8.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml

Comment thread .github/workflows/ci.yaml
@github-actions

Copy link
Copy Markdown

MoveIt Pro Example WS - Objectives Integration Test Report

@shaur-k shaur-k requested a review from JWhitleyWork June 22, 2026 17:32
Tag the auto-filed moveit_pro issue from the weekly sim integration
suite with the native "Bug" issue Type and the `example_ws` label so it
sorts into moveit_pro's triage. Applied best-effort: if the create
rejects the type/labels, retry with just title/body so the failure
notification still lands.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@shaur-k shaur-k force-pushed the claude/weekly-failure-issue-bug-type branch from cec81c8 to 7b6c61f Compare June 22, 2026 17:33
@JWhitleyWork JWhitleyWork enabled auto-merge June 22, 2026 17:46
@JWhitleyWork JWhitleyWork merged commit 6f44f84 into main Jun 22, 2026
13 checks passed
@JWhitleyWork JWhitleyWork deleted the claude/weekly-failure-issue-bug-type branch June 22, 2026 17:50
@github-actions

Copy link
Copy Markdown

MoveIt Pro Example WS - Objectives Integration Test Report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants