Add Bug type and example_ws label to weekly failure issue#730
Conversation
📝 WalkthroughWalkthroughThe CI workflow's ChangesCI Weekly Failure Notification
🔕 Pre-merge checks override appliedThe pre-merge checks have been overridden successfully. You can now proceed with the merge. Overridden by ❌ Failed checks (1 error)
✅ Passed checks (3 passed)
Comment |
|
Consider whether the change should land upstream in Overlapping files
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yaml:
- Around line 424-434: The catch block currently handles all errors the same way
by retrying the issues.create call without type/labels, which can cause
duplicate issues if the first create succeeded remotely but the response failed
locally. Modify the catch block to check if the error is specifically a
validation error (HTTP 422 status code) related to type or labels rejection, and
only then retry the issues.create call without those fields. For all other error
types, rethrow the exception instead of blindly retrying.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 42ec6368-812a-4509-82db-efdcd836280a
📒 Files selected for processing (1)
.github/workflows/ci.yaml
|
Tag the auto-filed moveit_pro issue from the weekly sim integration suite with the native "Bug" issue Type and the `example_ws` label so it sorts into moveit_pro's triage. Applied best-effort: if the create rejects the type/labels, retry with just title/body so the failure notification still lands. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
cec81c8 to
7b6c61f
Compare
|
What
The
weekly-failure-issuejob (from #721) files a GitHub issue onPickNikRobotics/moveit_prowhen the weekly sim integration suite fails. This tags that issue with:example_wslabel (marks repo-of-origin in moveit_pro's shared tracker).Both verified to exist in moveit_pro. The same
type: "Bug"pattern is already used by moveit_pro's owne2e-nightly.yaml/benchmarks-nightly.yaml.Fail-open
type/labelsare applied best-effort: theissues.createcall is wrapped so that if it rejects them (e.g. the "Bug" type is later renamed), it retries with justtitle/body. The failure notification must always land — same fail-open intent as the dedupe search above it. Without the wrap, a rejectedtypewould throw and silently drop the notification.Reviewed
code-reviewer+platform-architect-bot. The architect's blocker (unwrapped create dropping the notification) is fixed by the retry above.Notes for the reviewer
SISTER_REPOSGitHub App installation having Issues: write onmoveit_pro. That's a different grant than the commit-status write theintegration-statusjob uses, so it hasn't been exercised yet — please confirm the installation has it (if not, even the bare retry create fails). The weekly cron hasn't fired, so this path is still unrun.