Fix cecportcontroller null streamcec guard#1448
Merged
Merged
Conversation
…mproved event handling
…for VLAN and PoE changes
…se for missing device
…puts, enhance logging for route mapping
The cache wasn't being cleared correctly, and was an unnecessary add.
…essionRequestHandler
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates several Essentials components, primarily hardening CEC port handling around a potentially-null StreamCec while also introducing new configuration/API surface in routing, web handlers, and device-type interfaces.
Changes:
- Make
CecPortControllerresilient toPort.StreamCec == nulland attempt event subscription only when available. - Add optional Screen/Lift controller behaviors to disable auto-lower on power-on and auto-raise on power-off.
- Adjust several JSON/web/API and routing utilities (null-value JSON serialization, feedback web handler behavior, routing mapping/logging) and add new device-type interfaces.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/PepperDash.Essentials.MobileControl.Messengers/Messengers/DeviceStateMessageBase.cs | Adds null-ignoring serialization and marks Interfaces as obsolete. |
| src/PepperDash.Essentials.MobileControl.Messengers/Messengers/DeviceMessageBase.cs | Updates JSON serialization to omit null fields. |
| src/PepperDash.Essentials.Devices.Common/Displays/ScreenLiftControllerConfigProperties.cs | Adds config flags to disable auto lower/raise behaviors. |
| src/PepperDash.Essentials.Devices.Common/Displays/ScreenLiftController.cs | Honors new config flags when reacting to warming/cooling feedback. |
| src/PepperDash.Essentials.Core/Web/RequestHandlers/GetFeedbacksForDeviceRequestHandler.cs | Changes response behavior for missing devices (now returns 200 + empty payload). |
| src/PepperDash.Essentials.Core/Routing/Extensions.cs | Modifies routing mapping and removes “impossible route” cache; adds extra verbose logs. |
| src/PepperDash.Essentials.Core/DeviceTypeInterfaces/INetworkSwitchControl.cs | Introduces network switch interfaces for per-port VLAN/PoE and related event types. |
| src/PepperDash.Essentials.Core/DeviceTypeInterfaces/IHasWirelessSharing.cs | Adds a standard interface/event args for wireless sharing activity feedback. |
| src/PepperDash.Essentials.Core/Comm and IR/CecPortController.cs | Adds guarded subscription logic for StreamCec and updates send methods accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
aknous
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.