Skip to content

add SVT-AV1 4.0 as codec to iVSR#35

Open
sunzhenx wants to merge 1 commit into
OpenVisualCloud:masterfrom
sunzhenx:zhenx_dev
Open

add SVT-AV1 4.0 as codec to iVSR#35
sunzhenx wants to merge 1 commit into
OpenVisualCloud:masterfrom
sunzhenx:zhenx_dev

Conversation

@sunzhenx

Copy link
Copy Markdown

Add SVT-AV1 4.0 codec support for iVSR ffmpeg plugin integration.

soopel
soopel previously approved these changes Jun 25, 2026

@soopel soopel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soopel

soopel commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Hi @sunzhenx, the CI checks aren't running on this PR because the branch is based on an outdated master. The workflow runs are created but complete with no jobs, so there's nothing for maintainers to approve, and no checks appear.

Could you please update your branch? Either option works:

  1. Update your branch — merge the latest OpenVisualCloud/iVSR:master into zhenx_dev and push. This will re-trigger the workflows against the current base.
  2. Alternatively, enable "Allow edits by maintainers" on this PR so we can update the branch for you. (Only you, as the PR author, can toggle this — maintainers cannot.)

Once the branch is updated, the build/CodeQL/Trivy/Dependency-Review checks should run normally. Thanks!

@sunzhenx

Copy link
Copy Markdown
Author

Hi, @soopel I've done both steps to fix the CI issue:
1. Merged the latest OpenVisualCloud/iVSR:master into zhenx_dev and pushed the update to re-trigger the workflows.
2. Enabled "Allow edits by maintainers" on this PR.
Could you please check if the CI checks are now running correctly? Let me know if anything else is needed. Thanks!

@soopel soopel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@marcin-le marcin-le left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment applies to all usages of mentioned code in all files

ARG SVTAV1_REPO="https://gitlab.com/AOMediaCodec/SVT-AV1.git"
ARG SVTAV1_DIR=${WORKSPACE}/ivsr/svt-av1
WORKDIR ${SVTAV1_DIR}
RUN git clone ${SVTAV1_REPO} . && \

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use --branch and --depth 1 to speed up things

make install

# Build SVT-AV1
ARG SVTAV1_VER="v4.0.1"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why so old version? 3 days ago v4.2.0 was released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants