Reland "Support subscription crud api"#389
Merged
Merged
Conversation
* Run cargo sqlx prepare Signed-off-by: Björn Baron <bjorn@tweedegolf.com> * Misc tweaks to the subscription wire definitions Signed-off-by: Björn Baron <bjorn@tweedegolf.com> * Support subscription crud api Signed-off-by: Björn Baron <bjorn@tweedegolf.com> * Add test for empty objectOperations in Subscription Signed-off-by: Stefan van Ieperen <stefan@tweedegolf.com> Signed-off-by: Björn Baron <bjorn@tweedegolf.com> * Add clientName query param Signed-off-by: Björn Baron <bjorn@tweedegolf.com> * Support filtering subscriptions by target object type Signed-off-by: Björn Baron <bjorn@tweedegolf.com> * Support filtering subscriptions by program id Signed-off-by: Björn Baron <bjorn@tweedegolf.com> * Add MockSubscriptionSource to fix MockDataSource Signed-off-by: Björn Baron <bjorn@tweedegolf.com> * Review comments Signed-off-by: Björn Baron <bjorn@tweedegolf.com> * Add a test for an unspecified edge case Signed-off-by: Björn Baron <bjorn@tweedegolf.com> --------- Signed-off-by: Björn Baron <bjorn@tweedegolf.com> Signed-off-by: Stefan van Ieperen <stefan@tweedegolf.com> Co-authored-by: Stefan van Ieperen <stefan@tweedegolf.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
- Coverage 80.57% 79.75% -0.83%
==========================================
Files 45 47 +2
Lines 5242 5472 +230
==========================================
+ Hits 4224 4364 +140
- Misses 1018 1108 +90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pohlm01
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relands #386 which was temporarily reverted for the 0.2.0 release.