Upgrade to OpenADR 3.1#313
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
==========================================
- Coverage 80.88% 80.57% -0.31%
==========================================
Files 42 45 +3
Lines 4870 5242 +372
==========================================
+ Hits 3939 4224 +285
- Misses 931 1018 +87 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
In OpenADR 3.1 target filters are no longer typed. The set of target labels for a stored entity is represented as a list of strings. And for filtering you now use just a bunch of targets= query parameters. Signed-off-by: Björn Baron <bjorn@tweedegolf.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Björn Baron <bjorn@tweedegolf.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Björn Baron <bjorn@tweedegolf.com>
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
Signed-off-by: Björn Baron <bjorn@tweedegolf.com>
Signed-off-by: Björn Baron <bjorn@tweedegolf.com>
The test cases that are still failing are related to the new "object privacy" introduced by OpenADR 3.1 and will be corrected in a future commit. Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
Additionally, forbid setting the `venID` in `VenResourceRequest`. See also the corresponding issues in the spec repo: - oadr3-org/specification#380 - oadr3-org/specification#379 Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
* Run cargo sqlx prepare Signed-off-by: Björn Baron <bjorn@tweedegolf.com> * Misc tweaks to the subscription wire definitions Signed-off-by: Björn Baron <bjorn@tweedegolf.com> * Support subscription crud api Signed-off-by: Björn Baron <bjorn@tweedegolf.com> * Add test for empty objectOperations in Subscription Signed-off-by: Stefan van Ieperen <stefan@tweedegolf.com> Signed-off-by: Björn Baron <bjorn@tweedegolf.com> * Add clientName query param Signed-off-by: Björn Baron <bjorn@tweedegolf.com> * Support filtering subscriptions by target object type Signed-off-by: Björn Baron <bjorn@tweedegolf.com> * Support filtering subscriptions by program id Signed-off-by: Björn Baron <bjorn@tweedegolf.com> * Add MockSubscriptionSource to fix MockDataSource Signed-off-by: Björn Baron <bjorn@tweedegolf.com> * Review comments Signed-off-by: Björn Baron <bjorn@tweedegolf.com> * Add a test for an unspecified edge case Signed-off-by: Björn Baron <bjorn@tweedegolf.com> --------- Signed-off-by: Björn Baron <bjorn@tweedegolf.com> Signed-off-by: Stefan van Ieperen <stefan@tweedegolf.com> Co-authored-by: Stefan van Ieperen <stefan@tweedegolf.com>
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
|
All tests on OpenADR3-client pass now (tested on commit ca27a00), so we will merge when you have merged and released a stable version on this side. Thanks for all the hard work! |
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com> # Conflicts: # .github/workflows/checks.yml # Cargo.lock # Cargo.toml
|
@TeaDrinkingProgrammer I'm happy to hear we are passing your tests. Unfortunately, there is still a significant security loophole in the specification, see https://github.com/oadr3-org/specification/discussions/371#discussioncomment-16068667. I don't feel comfortable releasing a stable version of OpenLEADR quite yet, given that any possible fix is still a todo for us. Right now, any client can send a I suggest that I create another pre-release, and you continue working with that until this is addressed by the OpenADR Alliance in the specification. What do you think? |
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
|
Another pre-release works for us, I think we will release the client already since it works on our side, but I agree this issue needs to be resolved before a stable release. |
|
(also, don't forget to keep an eye on the DCO checks, happens to me all the time as well) |
* WIP Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com> * Separate WriteVen scope for BL and Ven Signed-off-by: Stefan van Ieperen <stefan@tweedegolf.com> * Additional tests Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com> --------- Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com> Signed-off-by: Stefan van Ieperen <stefan@tweedegolf.com> Co-authored-by: Stefan van Ieperen <stefan@tweedegolf.com>
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
This reverts commit eee4535 Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
|
@TeaDrinkingProgrammer, What is your opinion about #388? In short, we split the |
6bb067f to
54d4b57
Compare
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
No description provided.