Remove NBF claim requirement from jwt token - #252
Merged
Conversation
Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
nicburgt
force-pushed
the
remove-nbf-requirement-jwt
branch
from
July 28, 2025 12:26
d1ff3a3 to
2ee492c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
=======================================
Coverage 80.99% 80.99%
=======================================
Files 42 42
Lines 6092 6094 +2
=======================================
+ Hits 4934 4936 +2
Misses 1158 1158 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rnijveld
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This PR makes the
nbfclaim in the JWT token optional, since the OAUTH2 specification also defines it as optional. If thenbfclaim is present in a JWT token it will be validated by thejsonwebtokenlibrary through thevalidationobject.If the
nbfclaim is not present, validation for thenbfclaim is skipped as it is an optional claim.