Skip to content

Remove NBF claim requirement from jwt token - #252

Merged
rnijveld merged 1 commit into
OpenLEADR:mainfrom
nicburgt:remove-nbf-requirement-jwt
Aug 5, 2025
Merged

Remove NBF claim requirement from jwt token#252
rnijveld merged 1 commit into
OpenLEADR:mainfrom
nicburgt:remove-nbf-requirement-jwt

Conversation

@nicburgt

@nicburgt nicburgt commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

Hi!

This PR makes the nbf claim in the JWT token optional, since the OAUTH2 specification also defines it as optional. If the nbf claim is present in a JWT token it will be validated by the jsonwebtoken library through the validation object.

If the nbf claim is not present, validation for the nbf claim is skipped as it is an optional claim.

Signed-off-by: Nick van der Burgt <nvanderburgt@infiniot.nl>
@nicburgt
nicburgt force-pushed the remove-nbf-requirement-jwt branch from d1ff3a3 to 2ee492c Compare July 28, 2025 12:26
@codecov

codecov Bot commented Jul 28, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.99%. Comparing base (cf03f03) to head (2ee492c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #252   +/-   ##
=======================================
  Coverage   80.99%   80.99%           
=======================================
  Files          42       42           
  Lines        6092     6094    +2     
=======================================
+ Hits         4934     4936    +2     
  Misses       1158     1158           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rnijveld
rnijveld added this pull request to the merge queue Aug 5, 2025
Merged via the queue into OpenLEADR:main with commit ba7d4b6 Aug 5, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants