Skip to content

197 fetch oauth public key#214

Merged
pohlm01 merged 7 commits into
mainfrom
197-fetch-oauth-public-key
May 23, 2025
Merged

197 fetch oauth public key#214
pohlm01 merged 7 commits into
mainfrom
197-fetch-oauth-public-key

Conversation

@bramtweedegolf

Copy link
Copy Markdown
Contributor

For external OAuth servers, fetch OAuth public keys from well known location

Fixes #197

Signed-off-by: Bram Tweedegolf <bram@tweedegolf.com>
Signed-off-by: Bram Tweedegolf <bram@tweedegolf.com>
Signed-off-by: Bram Tweedegolf <bram@tweedegolf.com>
@bramtweedegolf bramtweedegolf requested a review from pohlm01 May 16, 2025 12:25
Signed-off-by: Bram Tweedegolf <bram@tweedegolf.com>
Signed-off-by: Bram Tweedegolf <bram@tweedegolf.com>
@codecov

codecov Bot commented May 16, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 49.50000% with 101 lines in your changes missing coverage. Please review.

Project coverage is 80.79%. Comparing base (b4d17be) to head (82d45de).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
openleadr-vtn/src/jwt.rs 14.89% 80 Missing ⚠️
openleadr-vtn/src/state.rs 87.14% 9 Missing ⚠️
openleadr-client/src/bin/cli.rs 0.00% 5 Missing ⚠️
openleadr-client/src/error.rs 0.00% 5 Missing ⚠️
openleadr-client/src/bin/everest.rs 0.00% 1 Missing ⚠️
openleadr-vtn/src/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   82.16%   80.79%   -1.37%     
==========================================
  Files          42       42              
  Lines        5690     5791     +101     
==========================================
+ Hits         4675     4679       +4     
- Misses       1015     1112      +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Bram Tweedegolf <bram@tweedegolf.com>
Signed-off-by: Bram Tweedegolf <bram@tweedegolf.com>
@bramtweedegolf bramtweedegolf changed the title [WIP] 197 fetch oauth public key 197 fetch oauth public key May 23, 2025
@bramtweedegolf bramtweedegolf marked this pull request as ready for review May 23, 2025 07:11
@bramtweedegolf

Copy link
Copy Markdown
Contributor Author

A very simple setup for testing with a mock extenal oauth server can be found here:

https://github.com/bramtweedegolf/oauth-mock-setup/blob/main/index.js

Maybe we can add this to a README of documentation somewhere?

@pohlm01 pohlm01 added this pull request to the merge queue May 23, 2025
Merged via the queue into main with commit cbcfa84 May 23, 2025
16 checks passed
@pohlm01 pohlm01 deleted the 197-fetch-oauth-public-key branch May 23, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fetch public key from OAuth server

2 participants