-
Notifications
You must be signed in to change notification settings - Fork 50
patina_internal_depex: Report protocol present status #1552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yangrongwei
wants to merge
5
commits into
OpenDevicePartnership:main
Choose a base branch
from
uefi-lab:ray-report-depex-log
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+43
−1
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d4a0688
patina_internal_depex: Report eval steps on demand
bea1472
simplify reporting logic & format
yangrongwei aa8fa25
adjust format and let clippy be happy
yangrongwei f02fd80
Change target name to "patina_depex_report'
yangrongwei bcc2168
remove target "patina_depex_report"
yangrongwei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -112,6 +112,27 @@ impl<P: PlatformInfo> PiDispatcher<P> { | |
| guid_fmt!(driver.file_name) | ||
| ); | ||
| } | ||
|
|
||
| if log::log_enabled!(target: "patina_internal_depex.report", log::Level::Debug) { | ||
| log::warn!("Begin Detail Report:"); | ||
| for driver in &mut self.dispatcher_context.lock().pending_drivers { | ||
|
yangrongwei marked this conversation as resolved.
Outdated
|
||
| log::warn!( | ||
| "Driver {} ({:?}) found but not dispatched.", | ||
| driver.name.as_deref().unwrap_or("Unnamed"), | ||
| guid_fmt!(driver.file_name) | ||
| ); | ||
|
|
||
| match &mut driver.depex { | ||
| Some(depex) => { | ||
| depex.eval_with_report(&PROTOCOL_DB.registered_protocols()); | ||
|
yangrongwei marked this conversation as resolved.
Outdated
|
||
| } | ||
|
yangrongwei marked this conversation as resolved.
Outdated
|
||
| _ => { | ||
| log::warn!(target: "patina_internal_depex.report", " No Depex"); | ||
| } | ||
| } | ||
| } | ||
| log::warn!("End Detail Report."); | ||
| } | ||
|
yangrongwei marked this conversation as resolved.
Outdated
|
||
| } | ||
|
Comment on lines
+117
to
136
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The messages in this "detailed report" should be at The normal case of a driver not dispatched is already covered by |
||
|
|
||
| /// Initializes the dispatcher by registering for FV protocol installation events. | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.