Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auto-rejoin best server selection #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
auto-rejoin best server selection #636
Changes from all commits
ba4203ea599e19cce3f848faa6d594e39c9File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
api.printedwaste.comstalls or accepts the connection without responding during the 15-second prefetch/post-disconnect fallback, this fetch has noAbortSignalor timeout, unlike the existingfetchPrintedWasteQueuepath. The IPC promise can remain pending, leavingprePingInFlightRefstuck and preventing auto-rejoin from falling back; wrap this request and JSON parse in the same timeout pattern used by the PrintedWaste service.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the queue API includes zones that the existing flow excludes, such as
nukedzones from the server mapping or non-standard/alliance entries, this loop still adds them and later treats a resolving hostname as eligible. The queue modal already requires standard non-nuked zones before routing; selecting a low-queue nuked zone here can send auto-rejoin to an unavailable CloudMatch LB and fail session creation, so fetch/use the mapping filter before adding candidates.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a user has the session proxy enabled, the subsequent session create/poll calls still use
activeSessionProxyUrl, but this IPC handler always calls the resolver withundefined, so queue fetching and latency selection are measured from the local network instead of the proxy egress. That can auto-rejoin proxy users to a region optimized for the wrong path; pass the enabled proxy URL through the IPC or read it from settings before calling the resolver.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.